Re: [PATCH] mac80211: minstrels: fix buffer overflow in HT debugfs rc_stats

2014-10-20 Thread Johannes Berg
On Sun, 2014-10-19 at 12:22 +0200, Karl Beldan wrote: > This would require rebasing "[PATCH v3 4/4] mac80211: minstrel_ht: add > basic support for VHT rates <= 3SS@80MHz", and send > > [PATCH v2] mac80211: minstrels: fix buffer overflow in HT debugfs > [PATCH v4 1/4] mac80211: minstrel_ht: Incre

Re: [PATCH] mac80211: minstrels: fix buffer overflow in HT debugfs rc_stats

2014-10-19 Thread Karl Beldan
Hi, If that's not too late I'd like to fix some coding style, replace: On Fri, Oct 17, 2014 at 08:34:00PM +0200, Karl Beldan wrote: > From: Karl Beldan > @@ -102,6 +102,8 @@ minstrel_stats_open(struct inode *inode, struct file > *file) > mi->sample_packets); > ms->le

Re: [PATCH] mac80211: minstrels: fix buffer overflow in HT debugfs rc_stats

2014-10-18 Thread Felix Fietkau
On 2014-10-17 20:34, Karl Beldan wrote: > From: Karl Beldan > > ATM an HT rc_stats line is 106 chars. > Times 8(MCS_GROUP_RATES)*3(SS)*2(GI)*2(BW) + CCK(4), i.e. x100, this is > well above the current 8192 - sizeof(*ms) currently allocated. > > Fix this by squeezing the output as follows (not th

[PATCH] mac80211: minstrels: fix buffer overflow in HT debugfs rc_stats

2014-10-17 Thread Karl Beldan
From: Karl Beldan ATM an HT rc_stats line is 106 chars. Times 8(MCS_GROUP_RATES)*3(SS)*2(GI)*2(BW) + CCK(4), i.e. x100, this is well above the current 8192 - sizeof(*ms) currently allocated. Fix this by squeezing the output as follows (not that we're short on memory but this also improves readab