Re: [PATCH] mwifiex: Use put_unaligned_le32

2017-10-06 Thread kbuild test robot
Hi Himanshu, [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.14-rc3 next-20170929] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Himanshu-Jha/mwifiex-Use-pu

Re: [PATCH] mwifiex: Use put_unaligned_le32

2017-10-06 Thread kbuild test robot
Hi Himanshu, [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.14-rc3 next-20170929] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Himanshu-Jha/mwifiex-Use-pu

Re: [PATCH] mwifiex: Use put_unaligned_le32

2017-10-06 Thread Kalle Valo
Himanshu Jha writes: > On Thu, Oct 05, 2017 at 11:02:50AM -0700, Brian Norris wrote: >> On Thu, Oct 05, 2017 at 08:52:33PM +0530, Himanshu Jha wrote: >> > There are various instances where a function used in file say for eg >> > int func_align (void* a) >> > is used and it is defined in align.h >

Re: [PATCH] mwifiex: Use put_unaligned_le32

2017-10-05 Thread Igor Mitsyanko
On 10/05/2017 12:07 PM, Himanshu Jha wrote: In this case, the key is CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. It seems that asm-generic/unaligned.h is set up to include different headers, based on the expected architecture behavior. Yes, asm-generic/unaligned.h looks more appopriate and is most

Re: [PATCH] mwifiex: Use put_unaligned_le32

2017-10-05 Thread Himanshu Jha
On Thu, Oct 05, 2017 at 11:02:50AM -0700, Brian Norris wrote: > On Thu, Oct 05, 2017 at 08:52:33PM +0530, Himanshu Jha wrote: > > There are various instances where a function used in file say for eg > > int func_align (void* a) > > is used and it is defined in align.h > > But many files don't *dire

Re: [PATCH] mwifiex: Use put_unaligned_le32

2017-10-05 Thread Brian Norris
On Thu, Oct 05, 2017 at 08:52:33PM +0530, Himanshu Jha wrote: > There are various instances where a function used in file say for eg > int func_align (void* a) > is used and it is defined in align.h > But many files don't *directly* include align.h and rather include > any other header which includ

Re: [PATCH] mwifiex: Use put_unaligned_le32

2017-10-05 Thread Himanshu Jha
On Thu, Oct 05, 2017 at 11:41:38AM +0300, Kalle Valo wrote: > Himanshu Jha writes: > > >> > --- a/drivers/net/wireless/marvell/mwifiex/cmdevt.c > >> > +++ b/drivers/net/wireless/marvell/mwifiex/cmdevt.c > >> > @@ -17,6 +17,7 @@ > >> > * this warranty disclaimer. > >> > */ > >> > > >> > +#in

Re: [PATCH] mwifiex: Use put_unaligned_le32

2017-10-05 Thread Kalle Valo
Himanshu Jha writes: >> > --- a/drivers/net/wireless/marvell/mwifiex/cmdevt.c >> > +++ b/drivers/net/wireless/marvell/mwifiex/cmdevt.c >> > @@ -17,6 +17,7 @@ >> > * this warranty disclaimer. >> > */ >> > >> > +#include >> >> I don't think this is correct. Should it be asm/unaligned.h? > >

Re: [PATCH] mwifiex: Use put_unaligned_le32

2017-10-05 Thread Himanshu Jha
On Thu, Oct 05, 2017 at 10:23:37AM +0300, Kalle Valo wrote: > Himanshu Jha writes: > > > Use put_unaligned_le32 rather than using byte ordering function and > > memcpy which makes code clear. > > Also, add the header file where it is declared. > > > > Done using Coccinelle and semantic patch used

Re: [PATCH] mwifiex: Use put_unaligned_le32

2017-10-05 Thread Kalle Valo
Himanshu Jha writes: > Use put_unaligned_le32 rather than using byte ordering function and > memcpy which makes code clear. > Also, add the header file where it is declared. > > Done using Coccinelle and semantic patch used is : > > @ rule1 @ > identifier tmp; expression ptr,x; type T; > @@ > > -

[PATCH] mwifiex: Use put_unaligned_le32

2017-10-04 Thread Himanshu Jha
Use put_unaligned_le32 rather than using byte ordering function and memcpy which makes code clear. Also, add the header file where it is declared. Done using Coccinelle and semantic patch used is : @ rule1 @ identifier tmp; expression ptr,x; type T; @@ - tmp = cpu_to_le32(x); <+... when != tm