Re: [PATCH] net: rfkill: gpio: Add default GPIO driver mappings for ACPI

2014-10-30 Thread Linus Walleij
On Mon, Oct 27, 2014 at 11:15 AM, Mika Westerberg wrote: > The driver uses devm_gpiod_get_index(..., index) so that the index refers > directly to the GpioIo resource under the ACPI device. The problem with > this is that if the ordering changes we get wrong GPIOs. > > With ACPI 5.1 _DSD we can n

Re: [PATCH] net: rfkill: gpio: Add default GPIO driver mappings for ACPI

2014-10-27 Thread John W. Linville
On Mon, Oct 27, 2014 at 12:23:55PM +0100, Johannes Berg wrote: > On Mon, 2014-10-27 at 12:15 +0200, Mika Westerberg wrote: > > The driver uses devm_gpiod_get_index(..., index) so that the index refers > > directly to the GpioIo resource under the ACPI device. The problem with > > this is that if th

Re: [PATCH] net: rfkill: gpio: Add default GPIO driver mappings for ACPI

2014-10-27 Thread Johannes Berg
On Mon, 2014-10-27 at 12:15 +0200, Mika Westerberg wrote: > The driver uses devm_gpiod_get_index(..., index) so that the index refers > directly to the GpioIo resource under the ACPI device. The problem with > this is that if the ordering changes we get wrong GPIOs. > > With ACPI 5.1 _DSD we can n

[PATCH] net: rfkill: gpio: Add default GPIO driver mappings for ACPI

2014-10-27 Thread Mika Westerberg
The driver uses devm_gpiod_get_index(..., index) so that the index refers directly to the GpioIo resource under the ACPI device. The problem with this is that if the ordering changes we get wrong GPIOs. With ACPI 5.1 _DSD we can now use names instead to reference GPIOs analogous to Device Tree. Ho