Re: [PATCH] nl80211: Update ERP info using NL80211_CMD_UPDATE_CONNECT_PARAMS

2018-04-04 Thread Arend van Spriel
On 4/4/2018 12:36 PM, Johannes Berg wrote: Hi, Started working on this and actually the "weird flags thing" is done for a reason. Maybe the reason was because it is done like that in the CMD_CONNECT case, but the better reason is that we need to return -EINVAL for "no-fils-offload-support,

Re: [PATCH] nl80211: Update ERP info using NL80211_CMD_UPDATE_CONNECT_PARAMS

2018-04-04 Thread Johannes Berg
Hi, > Started working on this and actually the "weird flags thing" is done for > a reason. Maybe the reason was because it is done like that in the > CMD_CONNECT case, but the better reason is that we need to return > -EINVAL for "no-fils-offload-support, any-fils-param" *and* >

Re: [PATCH] nl80211: Update ERP info using NL80211_CMD_UPDATE_CONNECT_PARAMS

2018-04-04 Thread Arend van Spriel
On 3/29/2018 1:31 PM, Arend van Spriel wrote: So yeah, I'd argue that what the patch needed was somebody taking a critical look at my review ;-) And perhaps fixing the weird flags thing I pointed out. Yup. That made sense. Hi Johannes, Started working on this and actually the "weird flags

Re: [PATCH] nl80211: Update ERP info using NL80211_CMD_UPDATE_CONNECT_PARAMS

2018-03-29 Thread Arend van Spriel
+ Jithu, Eylon On 3/29/2018 1:16 PM, Johannes Berg wrote: Hi Arend, Picking up a somewhat old thread as I did not see a follow-up on this patch. I got queried about it over here by our FILS team. So what is needed for this patch to pass the bar? That's indeed a bit old :-) + *

Re: [PATCH] nl80211: Update ERP info using NL80211_CMD_UPDATE_CONNECT_PARAMS

2018-03-29 Thread Johannes Berg
Hi Arend, > Picking up a somewhat old thread as I did not see a follow-up on this > patch. I got queried about it over here by our FILS team. So what is > needed for this patch to pass the bar? That's indeed a bit old :-) > > > + * @UPDATE_FILS_ERP_INFO: Indicates that FILS connection

Re: [PATCH] nl80211: Update ERP info using NL80211_CMD_UPDATE_CONNECT_PARAMS

2018-03-29 Thread Arend van Spriel
Hi Johannes, Picking up a somewhat old thread as I did not see a follow-up on this patch. I got queried about it over here by our FILS team. So what is needed for this patch to pass the bar? On 12/11/2017 12:12 PM, Johannes Berg wrote: On Wed, 2017-10-25 at 14:50 +0530, Vidyullatha

Re: [PATCH] nl80211: Update ERP info using NL80211_CMD_UPDATE_CONNECT_PARAMS

2017-12-11 Thread Johannes Berg
On Wed, 2017-10-25 at 14:50 +0530, Vidyullatha Kanchanapally wrote: > + * @UPDATE_FILS_ERP_INFO: Indicates that FILS connection parameters (realm, > + * username, erp sequence number and rrk) are updated > + * @UPDATE_AUTH_TYPE: Indicates that Authentication type is updated These are new here,

[PATCH] nl80211: Update ERP info using NL80211_CMD_UPDATE_CONNECT_PARAMS

2017-10-25 Thread Vidyullatha Kanchanapally
Use NL80211_CMD_UPDATE_CONNECT_PARAMS to update new ERP information, Association IEs and the Authentication type to driver / firmware which will be used in subsequent roamings. Signed-off-by: Vidyullatha Kanchanapally --- include/net/cfg80211.h | 5 +