Re: [PATCH] rtlwifi: Fix kernel oops introduced with commit e49656147359

2016-12-20 Thread Larry Finger
On 12/20/2016 05:21 AM, Kalle Valo wrote: Larry Finger writes: With commit e49656147359 {"rtlwifi: Use dev_kfree_skb_irq instead of kfree_skb"), the method used to free an skb was changed because the kfree_skb() was inside a spinlock. What was forgotten is that kfree_skb() guards against a NUL

Re: [PATCH] rtlwifi: Fix kernel oops introduced with commit e49656147359

2016-12-20 Thread Kalle Valo
Larry Finger writes: > With commit e49656147359 {"rtlwifi: Use dev_kfree_skb_irq instead of > kfree_skb"), the method used to free an skb was changed because the > kfree_skb() was inside a spinlock. What was forgotten is that kfree_skb() > guards against a NULL value for the argument. Routine dev

[PATCH] rtlwifi: Fix kernel oops introduced with commit e49656147359

2016-12-19 Thread Larry Finger
With commit e49656147359 {"rtlwifi: Use dev_kfree_skb_irq instead of kfree_skb"), the method used to free an skb was changed because the kfree_skb() was inside a spinlock. What was forgotten is that kfree_skb() guards against a NULL value for the argument. Routine dev_kfree_skb_irq() does not, and