Re: [PATCH] staging: wilc1000: remove wilc_sdio_init

2015-12-23 Thread Julian Calaby
Hi Glen, On Wed, Dec 23, 2015 at 1:33 PM, Glen Lee wrote: > wilc_sdio_init return always 1. It is needless, so just remove it and it's > related codes also. > > Signed-off-by: Glen Lee > --- > drivers/staging/wilc1000/wilc_sdio.c | 12 > 1

Re: [PATCH] staging: wilc1000: remove wilc_sdio_init

2015-12-23 Thread glen lee
On 2015년 12월 24일 11:39, Julian Calaby wrote: Hi Glen, On Wed, Dec 23, 2015 at 1:33 PM, Glen Lee wrote: wilc_sdio_init return always 1. It is needless, so just remove it and it's related codes also. Signed-off-by: Glen Lee ---

Re: [PATCH] staging: wilc1000: remove wilc_sdio_init

2015-12-23 Thread glen lee
On 2015년 12월 24일 12:07, Julian Calaby wrote: Hi Glen, On Thu, Dec 24, 2015 at 2:06 PM, glen lee wrote: On 2015년 12월 24일 11:39, Julian Calaby wrote: Hi Glen, On Wed, Dec 23, 2015 at 1:33 PM, Glen Lee wrote: wilc_sdio_init return always 1. It is

Re: [PATCH] staging: wilc1000: remove wilc_sdio_init

2015-12-23 Thread Julian Calaby
Hi Glen, On Thu, Dec 24, 2015 at 2:06 PM, glen lee wrote: > > > On 2015년 12월 24일 11:39, Julian Calaby wrote: >> >> Hi Glen, >> >> On Wed, Dec 23, 2015 at 1:33 PM, Glen Lee wrote: >>> >>> wilc_sdio_init return always 1. It is needless, so just remove it

Re: [PATCH] staging: wilc1000: remove wilc_sdio_init

2015-12-23 Thread Dan Carpenter
I kind of feel like we have started to err on the side of breaking things up into too many patches. Linus has said the same thing... This patch is not hard to review, except that the title was bad. Originally it was sent as: [PATCH] staging: wilc1000: fix bug in sdio/spi which is the correct

[PATCH] staging: wilc1000: remove wilc_sdio_init

2015-12-22 Thread Glen Lee
wilc_sdio_init return always 1. It is needless, so just remove it and it's related codes also. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_sdio.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_sdio.c