Larry Finger writes:
> On 10/4/18 8:42 AM, Stanislaw Gruszka wrote:
>> On Thu, Oct 04, 2018 at 03:39:55PM +0300, Kalle Valo wrote:
> Can we put the configuration file in the firmware directory?
> Should we package them into binary files? Or just put the raw data.
>
> We can test t
Stanislaw Gruszka writes:
> On Thu, Oct 04, 2018 at 03:39:55PM +0300, Kalle Valo wrote:
>> >> Can we put the configuration file in the firmware directory?
>> >> Should we package them into binary files? Or just put the raw data.
>> >>
>> >> We can test the performance for it. After we got the res
On Thu, Oct 04, 2018 at 11:19:59AM -0500, Larry Finger wrote:
> On 10/4/18 8:42 AM, Stanislaw Gruszka wrote:
> >On Thu, Oct 04, 2018 at 03:39:55PM +0300, Kalle Valo wrote:
> Can we put the configuration file in the firmware directory?
> Should we package them into binary files? Or just put
On 10/4/18 8:42 AM, Stanislaw Gruszka wrote:
On Thu, Oct 04, 2018 at 03:39:55PM +0300, Kalle Valo wrote:
Can we put the configuration file in the firmware directory?
Should we package them into binary files? Or just put the raw data.
We can test the performance for it. After we got the result,
On Thu, Oct 04, 2018 at 03:39:55PM +0300, Kalle Valo wrote:
> >> Can we put the configuration file in the firmware directory?
> >> Should we package them into binary files? Or just put the raw data.
> >>
> >> We can test the performance for it. After we got the result, we will make
> >> a decision
w Gruszka; Tony Chuang
>>> Cc: kv...@codeaurora.org; linux-wireless@vger.kernel.org; Pkshih; Andy
>>> Huang
>>> Subject: Re: [PATCH 01/12] rtwlan: main files
>>>
>>> On 10/2/18 5:29 AM, Stanislaw Gruszka wrote:
>>>>
Larry Finger writes:
> On 10/2/18 5:29 AM, Stanislaw Gruszka wrote:
>> On Fri, Sep 28, 2018 at 11:32:41AM +, Tony Chuang wrote:
if (rtw_hci_tx(rtwdev, &pkt_info, skb))
dev_kfree_skb_any(skb)
just to remove 'return;' and out label.
>>>
>>>
>>> OK, but why not
Stanislaw Gruszka writes:
> On Thu, Sep 27, 2018 at 10:40:44AM -0500, Larry Finger wrote:
>> On 9/27/18 8:50 AM, Stanislaw Gruszka wrote:
>> --snip
>>
>> >
>> > > +#define BIT_LEN_MASK_32(__bitlen) (0x >> (32 - (__bitlen)))
>> > > +#define BIT_OFFSET_LEN_MASK_32(__bitoffset, __bitlen)
Tony Chuang writes:
> Hi Kale & Stanislaw,
>
> I am working on the driver code and making some changes that Stanislaw
> have mentioned. And I expected that I will finish them tomorrow, what
> should I do after I finished them?
>
> Should I send an RFCv2, or start a new RFC for it ?
Like Stanisla
On Wed, Oct 03, 2018 at 03:25:37AM +, Tony Chuang wrote:
> Can I add you as Reviewed-by in RFCv2 ?
Not yet :-) I'm going to review all (v2) patches in detail,
not just first one, but this will take time. I'll post
Reviewed-by tag when done and if I will have no remarks.
> You helped me a lot
Huang
Subject: Re: [PATCH 01/12] rtwlan: main files
On 10/2/18 5:29 AM, Stanislaw Gruszka wrote:
On Fri, Sep 28, 2018 at 11:32:41AM +, Tony Chuang wrote:
if (rtw_hci_tx(rtwdev, &pkt_info, skb))
dev_kfree_skb_any(skb)
just to remove 'return;' and out label.
> -Original Message-
> From: Stanislaw Gruszka [mailto:sgrus...@redhat.com]
> Sent: Tuesday, October 02, 2018 6:14 PM
> To: Tony Chuang
> Cc: kv...@codeaurora.org; larry.fin...@lwfinger.net;
> linux-wireless@vger.kernel.org; Pkshih; Andy Huang
> Subject: Re: [PATC
> -Original Message-
> From: Larry Finger [mailto:larry.fin...@gmail.com] On Behalf Of Larry Finger
> Sent: Tuesday, October 02, 2018 11:24 PM
> To: Stanislaw Gruszka; Tony Chuang
> Cc: kv...@codeaurora.org; linux-wireless@vger.kernel.org; Pkshih; Andy
> Huang
> Subj
On 10/2/18 5:29 AM, Stanislaw Gruszka wrote:
On Fri, Sep 28, 2018 at 11:32:41AM +, Tony Chuang wrote:
if (rtw_hci_tx(rtwdev, &pkt_info, skb))
dev_kfree_skb_any(skb)
just to remove 'return;' and out label.
OK, but why not use ieee80211_free_txskb, should it be bett
On Fri, Sep 28, 2018 at 11:32:41AM +, Tony Chuang wrote:
> > if (rtw_hci_tx(rtwdev, &pkt_info, skb))
> > dev_kfree_skb_any(skb)
> >
> > just to remove 'return;' and out label.
>
>
> OK, but why not use ieee80211_free_txskb, should it be better for mac80211?
Yes, it is better
Hi
On Tue, Oct 02, 2018 at 09:35:35AM +, Tony Chuang wrote:
>
> Hi Kale & Stanislaw,
>
> I am working on the driver code and making some changes that Stanislaw
> have mentioned. And I expected that I will finish them tomorrow, what
> should I do after I finished them?
>
> Should I send an R
Hi Kale & Stanislaw,
I am working on the driver code and making some changes that Stanislaw
have mentioned. And I expected that I will finish them tomorrow, what
should I do after I finished them?
Should I send an RFCv2, or start a new RFC for it ? Because our driver will
be renamed from rtwlan
> -Original Message-
> From: Stanislaw Gruszka [mailto:sgrus...@redhat.com]
> Sent: Friday, September 28, 2018 5:29 PM
> To: Tony Chuang
> Cc: kv...@codeaurora.org; larry.fin...@lwfinger.net;
> linux-wireless@vger.kernel.org; Pkshih; Andy Huang
> Subject: Re: [PATC
Hi
On Fri, Sep 28, 2018 at 03:20:45AM +, Tony Chuang wrote:
> > > + rtw_tx_pkt_info_update(rtwdev, &pkt_info, control, skb);
> > > + if (rtw_hci_tx(rtwdev, &pkt_info, skb))
> > > + goto out;
> > > +
> > > + return;
> > > +
> > > +out:
> > > + dev_kfree_skb_any(skb);
> > This can be sim
On Thu, Sep 27, 2018 at 10:40:44AM -0500, Larry Finger wrote:
> On 9/27/18 8:50 AM, Stanislaw Gruszka wrote:
> --snip
>
> >
> > > +#define BIT_LEN_MASK_32(__bitlen) (0x >> (32 - (__bitlen)))
> > > +#define BIT_OFFSET_LEN_MASK_32(__bitoffset, __bitlen)
> > > \
> >
er.net;
> linux-wireless@vger.kernel.org; Pkshih; Andy Huang
> Subject: Re: [PATCH 01/12] rtwlan: main files
>
> Hi,
>
> Below is some more detailed review of first patch (with mostly
> nitpicks).
>
> On Fri, Sep 21, 2018 at 02:03:56PM +0800, yhchu...@realtek.com
On 9/27/18 8:50 AM, Stanislaw Gruszka wrote:
--snip
+#define BIT_LEN_MASK_32(__bitlen) (0x >> (32 - (__bitlen)))
+#define BIT_OFFSET_LEN_MASK_32(__bitoffset, __bitlen)
\
+ (BIT_LEN_MASK_32(__bitlen) << (__bitoffset))
+#define LE_P4BYTE_TO_HOST_4BYTE(__st
Hi,
Below is some more detailed review of first patch (with mostly
nitpicks).
On Fri, Sep 21, 2018 at 02:03:56PM +0800, yhchu...@realtek.com wrote:
> +static void rtw_ops_tx(struct ieee80211_hw *hw,
> +struct ieee80211_tx_control *control,
> +struct sk_buff
From: Yan-Hsuan Chuang
main files for Realtek 802.11ac wireless network chips
Signed-off-by: Yan-Hsuan Chuang
---
drivers/net/wireless/realtek/rtwlan/mac80211.c | 447 +
drivers/net/wireless/realtek/rtwlan/main.c | 1164 +++
drivers/net/wireless/realtek/rtwlan/
24 matches
Mail list logo
