Re: [PATCH 01/34] brcmfmac: Fix parameter order in brcmf_sdiod_f0_writeb()

On 07/08/17 12:25, Arend van Spriel wrote: >> All the other IO functions are the other way round in this >> driver. Make this one match. > > Core SDIO functions are indeed the other way around, but the IO > functions in this file use (addr, data) pattern. So should we aim to get > it all

Re: [PATCH 01/34] brcmfmac: Fix parameter order in brcmf_sdiod_f0_writeb()

Hi Ian, So it took me a while to get to this patch series. It is indeed way to big and not well structured making it difficult to review the patches on a per-patch basis. I decided to limit myself to looking at the patches involving bcmsdh.c doing a 'git log bcmsdh.c' on the applied

[PATCH 01/34] brcmfmac: Fix parameter order in brcmf_sdiod_f0_writeb()

All the other IO functions are the other way round in this driver. Make this one match. Signed-off-by: Ian Molton --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 01/34] brcmfmac: Fix parameter order in brcmf_sdiod_f0_writeb()

All the other IO functions are the other way round in this driver. Make this one match. Signed-off-by: Ian Molton --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git