On 30/08/17 19:59, Arend van Spriel wrote:
>> +static int brcmf_sdiod_reg_write(struct brcmf_sdio_dev *sdiodev, u32
>> addr,
>> + u8 regsz, void *data)
>
> Thought I mentioned this before, but the indentation should be aligned
> to opening bracket.
I checked this locally, and its
On 22-08-17 13:25, Ian Molton wrote:
This large function is concealing a LOT of obscure logic about
how the hardware functions. Time to split it up.
Again the tab. Guess it is your default ;-)
This first patch splits the function into two pieces - read and write,
doing away with the r
This large function is concealing a LOT of obscure logic about
how the hardware functions. Time to split it up.
This first patch splits the function into two pieces - read and write,
doing away with the rw flag in the process.
Signed-off-by: Ian Molton
Reviewed-by: Arend van Spriel
---