Re: [PATCH 08/34] brcmfmac: Fix uninitialised variable

2017-08-19 Thread Ian Molton
On 07/08/17 12:26, Arend van Spriel wrote: > On 7/26/2017 10:25 PM, Ian Molton wrote: >> Unlikely to be a problem, but brcmf_sdiod_regrb() is >> not symmetric with brcmf_sdiod_regrl() in this regard. > > You are pretty keen on symmetry, but you could also remove the > initialization in

Re: [PATCH 08/34] brcmfmac: Fix uninitialised variable

2017-08-07 Thread Arend van Spriel
On 7/26/2017 10:25 PM, Ian Molton wrote: Unlikely to be a problem, but brcmf_sdiod_regrb() is not symmetric with brcmf_sdiod_regrl() in this regard. You are pretty keen on symmetry, but you could also remove the initialization in brcmf_sdiod_regrl(). As long as no -Wunitialized pops

[PATCH 08/34] brcmfmac: Fix uninitialised variable

2017-07-26 Thread Ian Molton
Unlikely to be a problem, but brcmf_sdiod_regrb() is not symmetric with brcmf_sdiod_regrl() in this regard. Signed-off-by: Ian Molton --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 08/34] brcmfmac: Fix uninitialised variable

2017-07-19 Thread Ian Molton
Unlikely to be a problem, but brcmf_sdiod_regrb() is not symmetric with brcmf_sdiod_regrl() in this regard. Signed-off-by: Ian Molton --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git