[PATCH 09/21] staging: wilc1000: #ifdef conditionals cover entire functions

2015-07-28 Thread Tony Cho
This patch lets preprocessor conditionals (#ifdef) related to WILC_SDIO_IRQ_GPIO to compile out the entire functions. Compiling out the entire functions is preferred rather than portions of functions or expressions becausue doing so makes code harder to read. Signed-off-by: Tony Cho --- drivers/

Re: [PATCH 09/21] staging: wilc1000: #ifdef conditionals cover entire functions

2015-07-29 Thread Greg KH
On Tue, Jul 28, 2015 at 05:47:28PM +0900, Tony Cho wrote: > This patch lets preprocessor conditionals (#ifdef) related to > WILC_SDIO_IRQ_GPIO to compile out the entire functions. Compiling out > the entire functions is preferred rather than portions of functions or > expressions becausue doing so

Re: [PATCH 09/21] staging: wilc1000: #ifdef conditionals cover entire functions

2015-07-29 Thread Dan Carpenter
On Wed, Jul 29, 2015 at 01:54:54PM -0700, Greg KH wrote: > On Tue, Jul 28, 2015 at 05:47:28PM +0900, Tony Cho wrote: > > /** > > * Disable power sequencer > > **/ > > - if (!sdio_read_reg(WILC_MISC, ®)) { > > + if(!sdio_read_reg(WILC_MISC, ®)) { > I noticed this style chang

Re: [PATCH 09/21] staging: wilc1000: #ifdef conditionals cover entire functions

2015-07-29 Thread Greg KH
On Thu, Jul 30, 2015 at 12:14:08AM +0300, Dan Carpenter wrote: > On Wed, Jul 29, 2015 at 01:54:54PM -0700, Greg KH wrote: > > On Tue, Jul 28, 2015 at 05:47:28PM +0900, Tony Cho wrote: > > > /** > > >* Disable power sequencer > > >**/ > > > - if (!sdio_read_reg(WILC_MISC, ®)) { > > >

Re: [PATCH 09/21] staging: wilc1000: #ifdef conditionals cover entire functions

2015-07-29 Thread Dan Carpenter
Got it, thanks. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html