Re: [PATCH 1/1] staging: Fix bitshifts by wrong offsets in wilc1000/host_interface.c

2015-12-18 Thread Greg KH
On Tue, Dec 01, 2015 at 11:49:55PM -0300, Mario J. Rugiero wrote: > struct set_multicast uses (implicitly) sizeof(bool) to determine how many > bytes to copy in > Handle_SetMulticastFilter. Since that is implementation defined, it triggered > sparse to > rightfully complain about shifting a

Re: [PATCH 1/1] staging: Fix bitshifts by wrong offsets in wilc1000/host_interface.c

2015-12-18 Thread Mario J. Rugiero
El 18/12/15 a las 19:50, Greg KH escribió: On Tue, Dec 01, 2015 at 11:49:55PM -0300, Mario J. Rugiero wrote: struct set_multicast uses (implicitly) sizeof(bool) to determine how many bytes to copy in Handle_SetMulticastFilter. Since that is implementation defined, it triggered sparse to

[PATCH 1/1] staging: Fix bitshifts by wrong offsets in wilc1000/host_interface.c

2015-12-01 Thread Mario J. Rugiero
struct set_multicast uses (implicitly) sizeof(bool) to determine how many bytes to copy in Handle_SetMulticastFilter. Since that is implementation defined, it triggered sparse to rightfully complain about shifting a bigger value than supported. Since it was used as if assuming it was 32 bits, I