Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists

2015-09-30 Thread Chandra Gorentla
On Tue, Sep 29, 2015 at 05:31:53AM +0300, Dan Carpenter wrote: > On Mon, Sep 28, 2015 at 11:43:55PM +0530, Chandra S Gorentla wrote: > > - The message queue is replaced with standard Linux linked list > > - kmem_cache is used for list members > > - A check for return value of receive method is

Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists

2015-09-30 Thread Dan Carpenter
On Wed, Sep 30, 2015 at 06:12:50PM +0530, Chandra Gorentla wrote: > > > while (1) { > > > - wilc_mq_recv(, , sizeof(struct host_if_msg), > > > ); > > > + ret = wilc_mq_recv(, , > > > + sizeof(struct host_if_msg), ); > > > + if (ret) > > >

Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists

2015-09-30 Thread Chandra Gorentla
On Tue, Sep 29, 2015 at 02:44:02AM +0200, Greg KH wrote: > On Mon, Sep 28, 2015 at 11:43:55PM +0530, Chandra S Gorentla wrote: > > - The message queue is replaced with standard Linux linked list > > - kmem_cache is used for list members > > Why? The list entires are of fixed type and repeatedly

[PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists

2015-09-28 Thread Chandra S Gorentla
- The message queue is replaced with standard Linux linked list - kmem_cache is used for list members - A check for return value of receive method is added - GFP_ATOMIC is changed to GFP_KERNEL - A few other related minor changes Signed-off-by: Chandra S Gorentla ---

Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists

2015-09-28 Thread Dan Carpenter
On Mon, Sep 28, 2015 at 11:43:55PM +0530, Chandra S Gorentla wrote: > - The message queue is replaced with standard Linux linked list > - kmem_cache is used for list members > - A check for return value of receive method is added > - GFP_ATOMIC is changed to GFP_KERNEL > - A few other related

Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists

2015-09-28 Thread Greg KH
On Mon, Sep 28, 2015 at 11:43:55PM +0530, Chandra S Gorentla wrote: > - The message queue is replaced with standard Linux linked list > - kmem_cache is used for list members Why? > - A check for return value of receive method is added > - GFP_ATOMIC is changed to GFP_KERNEL Why? Are you