Re: [PATCH 1/3] ath10k: Fix shared WEP

2014-11-24 Thread Kalle Valo
Sujith Manoharan writes: > Kalle Valo wrote: >> No magic numbers, please. I didn't find anything for IV internals from >> ieee80211.h, not sure if we should add them there or just use ath10k >> internal defines. > > We are just retrieving the keyidx from the IV - not sure adding a couple > of mac

Re: [PATCH 1/3] ath10k: Fix shared WEP

2014-11-24 Thread Sujith Manoharan
Kalle Valo wrote: > No magic numbers, please. I didn't find anything for IV internals from > ieee80211.h, not sure if we should add them there or just use ath10k > internal defines. We are just retrieving the keyidx from the IV - not sure adding a couple of macros for "6" and "3" will make any dif

Re: [PATCH 1/3] ath10k: Fix shared WEP

2014-11-24 Thread Kalle Valo
Sujith Manoharan writes: > From: Sujith Manoharan > > When static keys are used in shared WEP, when a > station is associated, message 3 is sent with an > encrypted payload. But, for subsequent > authentications that are triggered without a > deauth, the auth frame is decrypted by the HW. > > To

[PATCH 1/3] ath10k: Fix shared WEP

2014-11-23 Thread Sujith Manoharan
From: Sujith Manoharan When static keys are used in shared WEP, when a station is associated, message 3 is sent with an encrypted payload. But, for subsequent authentications that are triggered without a deauth, the auth frame is decrypted by the HW. To handle this, check if the WEP keys have al