Re: [PATCH 13/13] ath10k: implement push-pull tx

2016-01-28 Thread Kalle Valo
Peter Oh writes: >> +spin_lock_bh(>htt.tx_lock); >> +ath10k_mac_tx_lock(ar, ATH10K_TX_PAUSE_Q_FLUSH_PENDING); >> +spin_unlock_bh(>htt.tx_lock); >> + > > Isn't it proved it break Mesh from working? Please think of others and edit your quotes, it was annoying to

Re: [PATCH 13/13] ath10k: implement push-pull tx

2016-01-26 Thread Michal Kazior
On 22 January 2016 at 08:47, Michal Kazior wrote: > On 21 January 2016 at 18:40, Peter Oh wrote: >> On 01/21/2016 05:46 AM, Michal Kazior wrote: [...] >>> - /* TODO: apply configuration */ >>> + rcu_read_unlock(); >>> + >>> +

Re: [PATCH 13/13] ath10k: implement push-pull tx

2016-01-26 Thread Peter Oh
On 01/26/2016 02:28 AM, Michal Kazior wrote: On 22 January 2016 at 08:47, Michal Kazior wrote: On 21 January 2016 at 18:40, Peter Oh wrote: On 01/21/2016 05:46 AM, Michal Kazior wrote: [...] - /* TODO: apply configuration */ +

Re: [PATCH 13/13] ath10k: implement push-pull tx

2016-01-21 Thread Peter Oh
On 01/21/2016 05:46 AM, Michal Kazior wrote: The current/old tx path design was that host, at its own leisure, pushed tx frames to the device. For HTT there was ~1000-1400 msdu queue depth. After reaching that limit the driver would request mac80211 to stop queues. There was little control

Re: [PATCH 13/13] ath10k: implement push-pull tx

2016-01-21 Thread Michal Kazior
On 21 January 2016 at 18:40, Peter Oh wrote: > > On 01/21/2016 05:46 AM, Michal Kazior wrote: >> >> The current/old tx path design was that host, at >> its own leisure, pushed tx frames to the device. >> For HTT there was ~1000-1400 msdu queue depth. >> >> After reaching that