Re: [PATCH 13/30] brcmfmac: Clarify if using braces.

2017-08-31 Thread Ian Molton
On 30/08/17 20:11, Arend van Spriel wrote: >> Whilst this if () statement is technically correct, it lacks clarity. > > I don't see the unclarity here. In my opinion people reading the code > should have a good level in C language and a decent level of curiosity > when they come across a

Re: [PATCH 13/30] brcmfmac: Clarify if using braces.

2017-08-30 Thread Arend van Spriel
On 22-08-17 13:25, Ian Molton wrote: Whilst this if () statement is technically correct, it lacks clarity. I don't see the unclarity here. In my opinion people reading the code should have a good level in C language and a decent level of curiosity when they come across a function/macro like

[PATCH 13/30] brcmfmac: Clarify if using braces.

2017-08-22 Thread Ian Molton
Whilst this if () statement is technically correct, it lacks clarity. Signed-off-by: Ian Molton --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git