Re: [PATCH 14/34] brcmfmac: Remove brcmf_sdiod_addrprep()

2017-08-19 Thread Ian Molton
On 07/08/17 12:27, Arend van Spriel wrote: > On 7/26/2017 10:25 PM, Ian Molton wrote: >> This function has become trivial enough that it may as well be pushed >> into >> its callers, which has the side-benefit of clarifying what's going on. >> >> Remove it, and rename

Re: [PATCH 14/34] brcmfmac: Remove brcmf_sdiod_addrprep()

2017-08-07 Thread Arend van Spriel
On 7/26/2017 10:25 PM, Ian Molton wrote: This function has become trivial enough that it may as well be pushed into its callers, which has the side-benefit of clarifying what's going on. Remove it, and rename brcmf_sdiod_set_sbaddr_window() to brcmf_sdiod_set_backplane_window() as it's easier

[PATCH 14/34] brcmfmac: Remove brcmf_sdiod_addrprep()

2017-07-26 Thread Ian Molton
This function has become trivial enough that it may as well be pushed into its callers, which has the side-benefit of clarifying what's going on. Remove it, and rename brcmf_sdiod_set_sbaddr_window() to brcmf_sdiod_set_backplane_window() as it's easier to understand. Signed-off-by: Ian Molton

[PATCH 14/34] brcmfmac: Remove brcmf_sdiod_addrprep()

2017-07-19 Thread Ian Molton
This function has become trivial enough that it may as well be pushed into its callers, which has the side-benefit of clarifying what's going on. Remove it, and rename brcmf_sdiod_set_sbaddr_window() to brcmf_sdiod_set_backplane_window() as it's easier to understand. Signed-off-by: Ian Molton