Re: [PATCH 160/306] mac80211-hwsim: add rate-limited debugging for rx-netlink

2017-02-27 Thread Johannes Berg
On Fri, 2017-02-24 at 07:27 -0800, Ben Greear wrote: > > On 02/23/2017 10:39 PM, Johannes Berg wrote: > > > > > + !info->attrs[HWSIM_ATTR_SIGNAL]) { > > > + if (net_ratelimit()) > > > + printk(KERN_DEBUG " hwsim rx-nl: Missing > > > required attribute\n"); > > > >

Re: [PATCH 160/306] mac80211-hwsim: add rate-limited debugging for rx-netlink

2017-02-24 Thread Ben Greear
On 02/23/2017 10:39 PM, Johannes Berg wrote: + !info->attrs[HWSIM_ATTR_SIGNAL]) { + if (net_ratelimit()) + printk(KERN_DEBUG " hwsim rx-nl: Missing required attribute\n"); I'm not convinced net_ratelimit() is a good idea, that's a global rate

Re: [PATCH 160/306] mac80211-hwsim: add rate-limited debugging for rx-netlink

2017-02-23 Thread Johannes Berg
> + !info->attrs[HWSIM_ATTR_SIGNAL]) { > + if (net_ratelimit()) > + printk(KERN_DEBUG " hwsim rx-nl: Missing > required attribute\n"); I'm not convinced net_ratelimit() is a good idea, that's a global rate limiter. johannes

[PATCH 160/306] mac80211-hwsim: add rate-limited debugging for rx-netlink

2017-02-23 Thread greearb
From: Ben Greear This makes it easier to understand why wmediumd (or similar) is getting errors when sending frames to the kernel. Signed-off-by: Ben Greear --- drivers/net/wireless/mac80211_hwsim.c | 42 ++- 1