Re: [PATCH 2/2] ath10k: support MAC address randomization in scan

> > > Is there a problem with the "supported commands" list? > > My understanding is that in general the "supported commands" list is not > well-maintained. Not every nl80211 command is represented in the list so > user-space can not know whether it is missing or not supported. > For this

Re: [PATCH 2/2] ath10k: support MAC address randomization in scan

+ Johannes (to confirm/correct my understanding regarding "supported commands") On 4/18/2018 4:35 AM, Dan Williams wrote: On Tue, 2018-04-17 at 15:26 -0700, Brian Norris wrote: On Tue, Apr 17, 2018 at 2:49 PM, Arend van Spriel wrote: On 4/17/2018 6:07 PM, Brian

Re: [PATCH 2/2] ath10k: support MAC address randomization in scan

On Tue, 2018-04-17 at 15:26 -0700, Brian Norris wrote: > On Tue, Apr 17, 2018 at 2:49 PM, Arend van Spriel > wrote: > > On 4/17/2018 6:07 PM, Brian Norris wrote: > > > On Tue, Apr 17, 2018 at 10:22:13AM +0200, Arend van Spriel wrote: > > > > I believe checking

Re: [PATCH 2/2] ath10k: support MAC address randomization in scan

On Tue, Apr 17, 2018 at 2:49 PM, Arend van Spriel wrote: > On 4/17/2018 6:07 PM, Brian Norris wrote: >> On Tue, Apr 17, 2018 at 10:22:13AM +0200, Arend van Spriel wrote: >>> I believe checking command support is not really recommended. Instead, you >>> better check

Re: [PATCH 2/2] ath10k: support MAC address randomization in scan

On 4/17/2018 6:07 PM, Brian Norris wrote: On Tue, Apr 17, 2018 at 10:22:13AM +0200, Arend van Spriel wrote: On 4/17/2018 2:28 AM, Brian Norris wrote: It looks like the status quo for looking for SCHED_SCAN support is to check if NL80211_CMD_START_SCHED_SCAN shows up in the command support

Re: [PATCH 2/2] ath10k: support MAC address randomization in scan

On Tue, Apr 17, 2018 at 10:22:13AM +0200, Arend van Spriel wrote: > On 4/17/2018 2:28 AM, Brian Norris wrote: > > It looks like the status quo for looking for SCHED_SCAN support is to > > check if NL80211_CMD_START_SCHED_SCAN shows up in the command support > > list. (IOW, that's what

Re: [PATCH 2/2] ath10k: support MAC address randomization in scan

On 4/17/2018 2:28 AM, Brian Norris wrote: Hi, On Mon, Apr 16, 2018 at 02:32:47PM +0300, Kalle Valo wrote: cjhu...@codeaurora.org writes: On 2018-04-14 05:13, Arend van Spriel wrote: On 4/13/2018 1:28 PM, Kalle Valo wrote: cjhu...@codeaurora.org writes: + if

Re: [PATCH 2/2] ath10k: support MAC address randomization in scan

Hi, On Mon, Apr 16, 2018 at 02:32:47PM +0300, Kalle Valo wrote: > cjhu...@codeaurora.org writes: > > On 2018-04-14 05:13, Arend van Spriel wrote: > >> On 4/13/2018 1:28 PM, Kalle Valo wrote: > >>> cjhu...@codeaurora.org writes: > >>> > >> + if (test_bit(WMI_SERVICE_SPOOF_MAC_SUPPORT,

Re: [PATCH 2/2] ath10k: support MAC address randomization in scan

cjhu...@codeaurora.org writes: > On 2018-04-14 05:13, Arend van Spriel wrote: >> On 4/13/2018 1:28 PM, Kalle Valo wrote: >>> cjhu...@codeaurora.org writes: >>> >> +if (test_bit(WMI_SERVICE_SPOOF_MAC_SUPPORT, ar->wmi.svc_map)) { >> +ret =

Re: [PATCH 2/2] ath10k: support MAC address randomization in scan

On 2018-04-13 19:28, Kalle Valo wrote: cjhu...@codeaurora.org writes: + if (test_bit(WMI_SERVICE_SPOOF_MAC_SUPPORT, ar->wmi.svc_map)) { + ret = ath10k_wmi_scan_prob_req_oui(ar, ar->mac_addr); + if (ret) { + ath10k_err(ar, "failed to set

Re: [PATCH 2/2] ath10k: support MAC address randomization in scan

On 2018-04-14 05:13, Arend van Spriel wrote: On 4/13/2018 1:28 PM, Kalle Valo wrote: cjhu...@codeaurora.org writes: + if (test_bit(WMI_SERVICE_SPOOF_MAC_SUPPORT, ar->wmi.svc_map)) { + ret = ath10k_wmi_scan_prob_req_oui(ar, ar->mac_addr); + if (ret) { +

Re: [PATCH 2/2] ath10k: support MAC address randomization in scan

On 4/13/2018 1:28 PM, Kalle Valo wrote: cjhu...@codeaurora.org writes: + if (test_bit(WMI_SERVICE_SPOOF_MAC_SUPPORT, ar->wmi.svc_map)) { + ret = ath10k_wmi_scan_prob_req_oui(ar, ar->mac_addr); + if (ret) { + ath10k_err(ar, "failed to set

Re: [PATCH 2/2] ath10k: support MAC address randomization in scan

cjhu...@codeaurora.org writes: >>> + if (test_bit(WMI_SERVICE_SPOOF_MAC_SUPPORT, ar->wmi.svc_map)) { >>> + ret = ath10k_wmi_scan_prob_req_oui(ar, ar->mac_addr); >>> + if (ret) { >>> + ath10k_err(ar, "failed to set prob req oui: %i\n", ret); >>> +

Re: [PATCH 2/2] ath10k: support MAC address randomization in scan

On 2018-04-13 04:59, Brian Norris wrote: Hi Carl, On Fri, Mar 30, 2018 at 11:14:00AM +0800, Carl Huang wrote: The ath10k reports the random_mac_addr capability to upper layer based on the service bit firmware reported. Driver sets the spoofed flag in scan_ctrl_flag to firmware if upper layer

Re: [PATCH 2/2] ath10k: support MAC address randomization in scan

Hi Carl, On Fri, Mar 30, 2018 at 11:14:00AM +0800, Carl Huang wrote: > The ath10k reports the random_mac_addr capability to upper layer > based on the service bit firmware reported. Driver sets the > spoofed flag in scan_ctrl_flag to firmware if upper layer has > enabled this feature in scan

[PATCH 2/2] ath10k: support MAC address randomization in scan

The ath10k reports the random_mac_addr capability to upper layer based on the service bit firmware reported. Driver sets the spoofed flag in scan_ctrl_flag to firmware if upper layer has enabled this feature in scan request. Test with QCA6174 hw3.0 and