Re: [PATCH 2/3] mac80211: multicast to unicast conversion

2016-10-03 Thread Johannes Berg
On Tue, 2016-10-04 at 06:36 +0200, M. Braun wrote: > Am 30.09.2016 um 09:29 schrieb Johannes Berg: > > > > > > > > +static ssize_t ieee80211_if_fmt_unicast( > > > + const struct ieee80211_sub_if_data *sdata, char *buf, > > > int > > > buflen) > > > > That's a very ... unusual way to break the li

Re: [PATCH 2/3] mac80211: multicast to unicast conversion

2016-10-03 Thread M. Braun
Am 30.09.2016 um 09:29 schrieb Johannes Berg: >> +static ssize_t ieee80211_if_fmt_unicast( >> +const struct ieee80211_sub_if_data *sdata, char *buf, int >> buflen) > > That's a very ... unusual way to break the lines here it is the same style as used in debugfs_netdev.c for other attributes,

Re: [PATCH 2/3] mac80211: multicast to unicast conversion

2016-09-30 Thread Johannes Berg
> +static ssize_t ieee80211_if_fmt_unicast( > + const struct ieee80211_sub_if_data *sdata, char *buf, int > buflen) That's a very ... unusual way to break the lines here - please either break after the first argument, or before the function name. You should see lots of examples for both. Howe

[PATCH 2/3] mac80211: multicast to unicast conversion

2016-09-25 Thread Michael Braun
This patch adds support for sending multicast data packets with ARP, IPv4 and IPv6 payload (possible 802.1q tagged) as 802.11 unicast frames to all stations. IEEE 802.11 multicast has well known issues, among them: 1. packets are not acked and hence not retransmitted, resulting in decreased r