Re: [PATCH 2/6] rsi: use enum for FSM states

2017-06-20 Thread Amitkumar Karwar
On Mon, Jun 19, 2017 at 8:49 PM, Kalle Valo wrote: > Amitkumar Karwar writes: > >> On Thu, Jun 15, 2017 at 8:14 PM, Kalle Valo wrote: >>> Amitkumar Karwar writes: >>> On Wed, Jun 14, 2017 at 2:43 PM, Kalle Valo wrote: > amit karwar writes: > >> On Tue, Jun 13, 2017 at 12:17 P

Re: [PATCH 2/6] rsi: use enum for FSM states

2017-06-19 Thread Kalle Valo
Amitkumar Karwar writes: > On Thu, Jun 15, 2017 at 8:14 PM, Kalle Valo wrote: >> Amitkumar Karwar writes: >> >>> On Wed, Jun 14, 2017 at 2:43 PM, Kalle Valo wrote: amit karwar writes: > On Tue, Jun 13, 2017 at 12:17 PM, Kalle Valo wrote: > >> Also your name in patchwork

Re: [PATCH 2/6] rsi: use enum for FSM states

2017-06-16 Thread Amitkumar Karwar
On Thu, Jun 15, 2017 at 8:14 PM, Kalle Valo wrote: > Amitkumar Karwar writes: > >> On Wed, Jun 14, 2017 at 2:43 PM, Kalle Valo wrote: >>> amit karwar writes: >>> On Tue, Jun 13, 2017 at 12:17 PM, Kalle Valo wrote: > Also your name in patchwork is not capitalised (patchwork is idi

Re: [PATCH 2/6] rsi: use enum for FSM states

2017-06-15 Thread Kalle Valo
Amitkumar Karwar writes: > On Wed, Jun 14, 2017 at 2:43 PM, Kalle Valo wrote: >> amit karwar writes: >> >>> On Tue, Jun 13, 2017 at 12:17 PM, Kalle Valo wrote: >>> Also your name in patchwork is not capitalised (patchwork is idiotic and takes the name from patchwork user data and not

Re: [PATCH 2/6] rsi: use enum for FSM states

2017-06-14 Thread Amitkumar Karwar
On Wed, Jun 14, 2017 at 2:43 PM, Kalle Valo wrote: > amit karwar writes: > >> On Tue, Jun 13, 2017 at 12:17 PM, Kalle Valo wrote: >>> Amitkumar Karwar writes: >>> Currently macros are used for FSM states. We will replace it with enum so that new state can be added easily without

Re: [PATCH 2/6] rsi: use enum for FSM states

2017-06-14 Thread Kalle Valo
amit karwar writes: > On Tue, Jun 13, 2017 at 12:17 PM, Kalle Valo wrote: >> Amitkumar Karwar writes: >> >>> Currently macros are used for FSM states. We will replace >>> it with enum so that new state can be added easily without >>> worrying about macro value. >>> >>> Signed-off-by: Amitkumar

Re: [PATCH 2/6] rsi: use enum for FSM states

2017-06-13 Thread amit karwar
On Tue, Jun 13, 2017 at 12:17 PM, Kalle Valo wrote: > Amitkumar Karwar writes: > >> Currently macros are used for FSM states. We will replace >> it with enum so that new state can be added easily without >> worrying about macro value. >> >> Signed-off-by: Amitkumar Karwar > > From and Signed-off

Re: [PATCH 2/6] rsi: use enum for FSM states

2017-06-12 Thread Kalle Valo
Amitkumar Karwar writes: > Currently macros are used for FSM states. We will replace > it with enum so that new state can be added easily without > worrying about macro value. > > Signed-off-by: Amitkumar Karwar >From and Signed-off-by does not match (gmail.com vs redpinesignals.com). I suggest

[PATCH 2/6] rsi: use enum for FSM states

2017-06-02 Thread Amitkumar Karwar
Currently macros are used for FSM states. We will replace it with enum so that new state can be added easily without worrying about macro value. Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_main.h | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --