Re: [PATCH 3/3] cfg80211: Specify the reason for connect timeout

2017-01-12 Thread Malinen, Jouni
On Thu, Jan 12, 2017 at 03:32:20PM +0100, Johannes Berg wrote: > > > We don't.. This discussion here is about the C API where we cannot > > remove the argument from the call without adding yet another inline > > wrapper, but the actual function that generates the netlink message > > does not add t

Re: [PATCH 3/3] cfg80211: Specify the reason for connect timeout

2017-01-12 Thread Johannes Berg
> We don't.. This discussion here is about the C API where we cannot > remove the argument from the call without adding yet another inline > wrapper, but the actual function that generates the netlink message > does not add the timeout reason attribute for success or explicit > rejection cases. A

Re: [PATCH 3/3] cfg80211: Specify the reason for connect timeout

2017-01-12 Thread Malinen, Jouni
On Thu, Jan 12, 2017 at 03:06:19PM +0100, Johannes Berg wrote: > On Thu, 2017-01-12 at 13:58 +, Malinen, Jouni wrote: > > > > > I think this description is misleading - one could easily > > > understand > > > "for other cases" to indicate for the cases that the AP did > > > explicitly > > > re

Re: [PATCH 3/3] cfg80211: Specify the reason for connect timeout

2017-01-12 Thread Johannes Berg
On Thu, 2017-01-12 at 13:58 +, Malinen, Jouni wrote: > > > I think this description is misleading - one could easily > > understand > > "for other cases" to indicate for the cases that the AP did > > explicitly > > reject it, but that's obviously not true. > > Well, the expectation here reall

Re: [PATCH 3/3] cfg80211: Specify the reason for connect timeout

2017-01-12 Thread Malinen, Jouni
On Wed, Jan 11, 2017 at 02:26:06PM +0100, Johannes Berg wrote: > On Wed, 2017-01-11 at 13:13 +, Malinen, Jouni wrote: > > > > > > @@ -172,6 +174,7 @@ static int cfg80211_conn_do_work(struct > > > > wireless_dev *wdev) > > > >   case CFG80211_CONN_AUTH_FAILED: > > > > + *tre

Re: [PATCH 3/3] cfg80211: Specify the reason for connect timeout

2017-01-12 Thread Malinen, Jouni
On Wed, Jan 11, 2017 at 02:31:31PM +0100, Johannes Berg wrote: > > + * @timeout_reason: reason for connection timeout. This is used when > > the > > + * connection fails due to a timeout instead of an explicit > > rejection from > > + * the AP. 0 (NL80211_CONNECT_TIMEOUT_UNSPECIFIED) is used > > fo

Re: [PATCH 3/3] cfg80211: Specify the reason for connect timeout

2017-01-11 Thread Johannes Berg
> + * @timeout_reason: reason for connection timeout. This is used when > the > + * connection fails due to a timeout instead of an explicit > rejection from > + * the AP. 0 (NL80211_CONNECT_TIMEOUT_UNSPECIFIED) is used > for other cases. I think this description is misleading - one could easi

Re: [PATCH 3/3] cfg80211: Specify the reason for connect timeout

2017-01-11 Thread Johannes Berg
On Wed, 2017-01-11 at 13:13 +, Malinen, Jouni wrote: > > > > @@ -172,6 +174,7 @@ static int cfg80211_conn_do_work(struct > > > wireless_dev *wdev) > > >   case CFG80211_CONN_AUTH_FAILED: > > > + *treason = NL80211_TIMEOUT_AUTH; > > > > ... but it seems AUTH failure always is a timeout

Re: [PATCH 3/3] cfg80211: Specify the reason for connect timeout

2017-01-11 Thread Malinen, Jouni
On Mon, Jan 09, 2017 at 09:24:56PM +0100, Arend Van Spriel wrote: > > diff --git a/net/wireless/sme.c b/net/wireless/sme.c > > @@ -38,6 +38,7 @@ struct cfg80211_conn { > > CFG80211_CONN_ASSOCIATE_NEXT, > > CFG80211_CONN_ASSOCIATING, > > CFG80211_CONN_ASSOC_FAILED

Re: [PATCH 3/3] cfg80211: Specify the reason for connect timeout

2017-01-09 Thread Arend Van Spriel
On 9-1-2017 18:53, Jouni Malinen wrote: > From: Purushottam Kushwaha > > This enhances the connect timeout API to also carry the reason for the > timeout. These reason codes for the connect time out are represented by > enum nl80211_timeout_reason and are passed to user space through a new > attr

[PATCH 3/3] cfg80211: Specify the reason for connect timeout

2017-01-09 Thread Jouni Malinen
From: Purushottam Kushwaha This enhances the connect timeout API to also carry the reason for the timeout. These reason codes for the connect time out are represented by enum nl80211_timeout_reason and are passed to user space through a new attribute NL80211_ATTR_TIMEOUT_REASON (u32). Signed-off