Re: [PATCH 3/3] mac80211: fix VLAN handling with TXQs

2017-09-05 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > On Tue, 2017-09-05 at 11:49 +0200, Toke Høiland-Jørgensen wrote: >> >> Ah, so the station is attached to the VLAN interface, not the parent >> interface? > > Doesn't actually matter, but if the VLAN goes where the station belongs > then either the station must've moved so

Re: [PATCH 3/3] mac80211: fix VLAN handling with TXQs

2017-09-05 Thread Johannes Berg
On Tue, 2017-09-05 at 11:49 +0200, Toke Høiland-Jørgensen wrote: > > Ah, so the station is attached to the VLAN interface, not the parent > interface? Doesn't actually matter, but if the VLAN goes where the station belongs then either the station must've moved somewhere else or have been destroye

Re: [PATCH 3/3] mac80211: fix VLAN handling with TXQs

2017-09-05 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > On Tue, 2017-09-05 at 11:02 +0200, Toke Høiland-Jørgensen wrote: >> >> > I'm not sure. However, I think it's less bad than one might guess >> > since it really should only affect multicast frames, right? All >> > unicast frames should go directly to the per-STA TXQ. >> >

Re: [PATCH 3/3] mac80211: fix VLAN handling with TXQs

2017-09-05 Thread Johannes Berg
On Tue, 2017-09-05 at 11:02 +0200, Toke Høiland-Jørgensen wrote: > > > I'm not sure. However, I think it's less bad than one might guess > > since it really should only affect multicast frames, right? All > > unicast frames should go directly to the per-STA TXQ. > > Ah, right, that is the interfa

Re: [PATCH 3/3] mac80211: fix VLAN handling with TXQs

2017-09-05 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > On Mon, 2017-09-04 at 16:23 +0200, Toke Høiland-Jørgensen wrote: >> >> Hmm, not apart from agreeing with you that it would be better to not >> drop everything when removing a VLAN. Not sure how often this >> happens, though (and hence how big of a problem it is). What hap

Re: [PATCH 3/3] mac80211: fix VLAN handling with TXQs

2017-09-04 Thread Johannes Berg
On Mon, 2017-09-04 at 16:23 +0200, Toke Høiland-Jørgensen wrote: > > Hmm, not apart from agreeing with you that it would be better to not > drop everything when removing a VLAN. Not sure how often this > happens, though (and hence how big of a problem it is). What happens > in scenarios where host

Re: [PATCH 3/3] mac80211: fix VLAN handling with TXQs

2017-09-04 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > On Mon, 2017-08-21 at 15:32 +0200, Toke Høiland-Jørgensen wrote: >> >> > + struct ieee80211_vif *vif; >> >   struct ieee80211_key_conf *hw_key; >> >   u32 flags; >> > - /* 4 bytes free */ >> > +

Re: [PATCH 3/3] mac80211: fix VLAN handling with TXQs

2017-09-04 Thread Johannes Berg
On Mon, 2017-08-21 at 15:32 +0200, Toke Høiland-Jørgensen wrote: > > > + struct ieee80211_vif *vif; > >   struct ieee80211_key_conf *hw_key; > >   u32 flags; > > - /* 4 bytes free */ > > + codel_time_t enqueu

Re: [PATCH 3/3] mac80211: fix VLAN handling with TXQs

2017-08-21 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > diff --git a/include/net/mac80211.h b/include/net/mac80211.h > index b2b5419467cc..263cb30d77c8 100644 > --- a/include/net/mac80211.h > +++ b/include/net/mac80211.h > @@ -919,21 +919,10 @@ struct ieee80211_tx_info { > unsigned long jiffies; >

[PATCH 3/3] mac80211: fix VLAN handling with TXQs

2017-06-22 Thread Johannes Berg
From: Johannes Berg With TXQs, the AP_VLAN interfaces are resolved to their owner AP interface when enqueuing the frame, which makes sense since the frame really goes out on that as far as the driver is concerned. However, this introduces a problem: frames to be encrypted with a VLAN-specific GT