RE: [PATCH 3/5] mwifiex: do not free firmware dump memory in shutdown_drv

2016-10-25 Thread Amitkumar Karwar
Hi Dmitry, > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] > Sent: Tuesday, October 25, 2016 5:47 AM > To: Amitkumar Karwar > Cc: linux-wireless@vger.kernel.org; Cathy Luo; Nishant Sarmukadam; > briannor...@google.com; Xinming Hu > Subject: Re: [PATCH 3/5] mwifiex: do

Re: [PATCH 3/5] mwifiex: do not free firmware dump memory in shutdown_drv

2016-10-24 Thread Dmitry Torokhov
On Mon, Oct 24, 2016 at 07:51:30PM +0530, Amitkumar Karwar wrote: > From: Xinming Hu > > mwifiex_upload_device_dump() already takes care of freeing firmware dump > memory. Doing the same thing in mwifiex_shutdown_drv() is redundant. > > Signed-off-by: Xinming Hu > Signed-off-by: Amitkumar Karwa

Re: [PATCH 3/5] mwifiex: do not free firmware dump memory in shutdown_drv

2016-10-24 Thread Brian Norris
On Mon, Oct 24, 2016 at 07:51:30PM +0530, Amitkumar Karwar wrote: > From: Xinming Hu > > mwifiex_upload_device_dump() already takes care of freeing firmware dump > memory. Doing the same thing in mwifiex_shutdown_drv() is redundant. > > Signed-off-by: Xinming Hu > Signed-off-by: Amitkumar Karwa

[PATCH 3/5] mwifiex: do not free firmware dump memory in shutdown_drv

2016-10-24 Thread Amitkumar Karwar
From: Xinming Hu mwifiex_upload_device_dump() already takes care of freeing firmware dump memory. Doing the same thing in mwifiex_shutdown_drv() is redundant. Signed-off-by: Xinming Hu Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/marvell/mwifiex/init.c | 19 --- 1