[PATCH 6/6] mac80211/wpa: use constant time memory comparison for MACs

2017-06-09 Thread Jason A. Donenfeld
Otherwise, we enable all sorts of forgeries via timing attack. Signed-off-by: Jason A. Donenfeld Cc: Johannes Berg Cc: linux-wireless@vger.kernel.org Cc: sta...@vger.kernel.org --- net/mac80211/wpa.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/net/mac80211/wpa.c

Re: [PATCH 6/6] mac80211/wpa: use constant time memory comparison for MACs

2017-06-13 Thread Johannes Berg
On Sat, 2017-06-10 at 04:59 +0200, Jason A. Donenfeld wrote: > Otherwise, we enable all sorts of forgeries via timing attack. I'm not really sure that this is actually true, since you don't get much feedback on your frame that's dropped, especially if you're attacking from remote. Basically, I don

Re: [PATCH 6/6] mac80211/wpa: use constant time memory comparison for MACs

2017-06-13 Thread Jason A. Donenfeld
On Tue, Jun 13, 2017 at 10:20 AM, Johannes Berg wrote: > I'm not really sure that this is actually true, since you don't get > much feedback on your frame that's dropped, especially if you're > attacking from remote. Basically, I don't see how you can observe the > timing of this operation? There