Re: [PATCH RFC 2/2] brcmfmac: add brcmf_err_pub macro for better error messages

2017-01-20 Thread Rafał Miłecki
On 20 January 2017 at 12:37, Arend Van Spriel wrote: > On 20-1-2017 12:17, Rafał Miłecki wrote: >> On 01/20/2017 11:26 AM, Arend Van Spriel wrote: >>> On 18-1-2017 15:27, Rafał Miłecki wrote: From: Rafał Miłecki This macro accepts an extra argument of struct brcmf_pub pointer. It >

Re: [PATCH RFC 2/2] brcmfmac: add brcmf_err_pub macro for better error messages

2017-01-20 Thread Arend Van Spriel
On 20-1-2017 12:17, Rafał Miłecki wrote: > On 01/20/2017 11:26 AM, Arend Van Spriel wrote: >> On 18-1-2017 15:27, Rafał Miłecki wrote: >>> From: Rafał Miłecki >>> >>> This macro accepts an extra argument of struct brcmf_pub pointer. It >>> allows referencing struct device and printing error using

Re: [PATCH RFC 2/2] brcmfmac: add brcmf_err_pub macro for better error messages

2017-01-20 Thread Rafał Miłecki
On 01/20/2017 11:26 AM, Arend Van Spriel wrote: On 18-1-2017 15:27, Rafał Miłecki wrote: From: Rafał Miłecki This macro accepts an extra argument of struct brcmf_pub pointer. It allows referencing struct device and printing error using dev_err. This is very useful on devices with more than one

Re: [PATCH RFC 2/2] brcmfmac: add brcmf_err_pub macro for better error messages

2017-01-20 Thread Arend Van Spriel
On 18-1-2017 15:27, Rafał Miłecki wrote: > From: Rafał Miłecki > > This macro accepts an extra argument of struct brcmf_pub pointer. It > allows referencing struct device and printing error using dev_err. This > is very useful on devices with more than one wireless card suppored by > brcmfmac.

[PATCH RFC 2/2] brcmfmac: add brcmf_err_pub macro for better error messages

2017-01-18 Thread Rafał Miłecki
From: Rafał Miłecki This macro accepts an extra argument of struct brcmf_pub pointer. It allows referencing struct device and printing error using dev_err. This is very useful on devices with more than one wireless card suppored by brcmfmac. Thanks for dev_err it's possible to identify device tha