Re: [PATCH V2 02/10] nl80211: allow multiple active scheduled scan requests

2017-04-18 Thread Arend van Spriel
On 4/18/2017 10:55 AM, Johannes Berg wrote: On Tue, 2017-04-18 at 10:53 +0200, Johannes Berg wrote: Hi Arend, Overall this looks good, and I've almost applied it - but I have a question on this patch. You have this list: + struct list_head sched_scan_req_list; struct

Re: [PATCH V2 02/10] nl80211: allow multiple active scheduled scan requests

2017-04-18 Thread Johannes Berg
On Tue, 2017-04-18 at 10:53 +0200, Johannes Berg wrote: > Hi Arend, > > Overall this looks good, and I've almost applied it - but I have a > question on this patch. > > You have this list: > > > + struct list_head sched_scan_req_list; > >   struct cfg80211_sched_scan_request __rcu

Re: [PATCH V2 02/10] nl80211: allow multiple active scheduled scan requests

2017-04-18 Thread Johannes Berg
Hi Arend, Overall this looks good, and I've almost applied it - but I have a question on this patch. You have this list: > + struct list_head sched_scan_req_list; >  struct cfg80211_sched_scan_request __rcu *sched_scan_req; but you kept this. In fact, it's even still *used*. I don't

[PATCH V2 02/10] nl80211: allow multiple active scheduled scan requests

2017-04-13 Thread Arend van Spriel
This patch implements the idea to have multiple scheduled scan requests running concurrently. It mainly illustrates how to deal with the incoming request from user-space in terms of backward compatibility. In order to use multiple scheduled scans user-space needs to provide a flag attribute