Re: [PATCH V2 1/5] staging: wilc1000: #ifdef conditionals cover entire functions

2015-07-30 Thread Greg KH
On Fri, Jul 31, 2015 at 12:27:04PM +0900, tony.cho wrote: > > > On 2015년 07월 30일 20:56, Sudip Mukherjee wrote: > >On Thu, Jul 30, 2015 at 06:10:10PM +0900, Tony Cho wrote: > >>This patch lets preprocessor conditionals (#ifdef) related to > >>WILC_SDIO_IRQ_GPIO to compile out the entire functions.

Re: [PATCH V2 1/5] staging: wilc1000: #ifdef conditionals cover entire functions

2015-07-30 Thread Sudip Mukherjee
On Thu, Jul 30, 2015 at 06:10:10PM +0900, Tony Cho wrote: > This patch lets preprocessor conditionals (#ifdef) related to > WILC_SDIO_IRQ_GPIO to compile out the entire functions. Compiling out > the entire functions is preferred rather than portions of functions or > expressions becausue doing so

Re: [PATCH V2 1/5] staging: wilc1000: #ifdef conditionals cover entire functions

2015-07-30 Thread Johnny Kim
Your patch has wrong sentence. Please remove "---" ASCHI Loot at below line. On 2015년 07월 30일 18:10, Tony Cho wrote: This patch lets preprocessor conditionals (#ifdef) related to WILC_SDIO_IRQ_GPIO to compile out the entire functions. Compiling out the entire functions is preferred rather than p

[PATCH V2 1/5] staging: wilc1000: #ifdef conditionals cover entire functions

2015-07-30 Thread Tony Cho
This patch lets preprocessor conditionals (#ifdef) related to WILC_SDIO_IRQ_GPIO to compile out the entire functions. Compiling out the entire functions is preferred rather than portions of functions or expressions becausue doing so makes code harder to read. Signed-off-by: Tony Cho --- V2: Remov