Re: [PATCH V3] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets

2016-11-17 Thread Johannes Berg
> > > It's probably worth having a discussion about this behaviour > > > difference - not necessarily in the context of this driver > > > submission though. > > > > Do you mean that default is to allow to dynamically allocate > > resources (add_interface) for as much interfaces as memory allows,

Re: [PATCH V3] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets

2016-11-16 Thread Johannes Berg
> > > +static int qtnf_pcie_init_shm_ipc(struct qtnf_pcie_bus_priv > > > *priv) > > > +{ > > > + struct qtnf_shm_ipc_region __iomem *ipc_tx_reg; > > > + struct qtnf_shm_ipc_region __iomem *ipc_rx_reg; > > > + const struct qtnf_shm_ipc_int ipc_int = { > > qtnf_ipc_gen_ep_int, priv }; > > > > > >

Re: [PATCH V3] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets

2016-11-16 Thread IgorMitsyanko
Resending because previous attempt was rejected by vger.kernel.org On 11/16/2016 06:04 PM, IgorMitsyanko wrote: On 11/14/2016 12:52 PM, Johannes Berg wrote: +++ b/drivers/net/wireless/quantenna/qtnfmac/Kconfig @@ -0,0 +1,23 @@ +config QTNFMAC + tristate "Quantenna WiFi FullMAC WLAN

Re: [PATCH V3] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets

2016-11-16 Thread IgorMitsyanko
On 11/15/2016 12:06 PM, Johannes Berg wrote: On Wed, 2016-11-09 at 17:00 +0300, igor.mitsyanko...@quantenna.com wrote: +static int +qtnf_change_virtual_intf(struct wiphy *wiphy, +struct net_device *dev, +enum nl80211_iftype type, u32 *flags, +

Re: [PATCH V3] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets

2016-11-14 Thread Johannes Berg
> +++ b/drivers/net/wireless/quantenna/qtnfmac/Kconfig > @@ -0,0 +1,23 @@ > +config QTNFMAC > + tristate "Quantenna WiFi FullMAC WLAN driver" > + default n No need to state that default explicitly, but it also doesn't really matter. > +   it as a module, it will be called