Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

On 4/5/2018 3:10 PM, Kalle Valo wrote: Ulf Hansson writes: On 20 March 2018 at 10:55, Kalle Valo wrote: Arend van Spriel writes: If I get it right, you mean something like this: mmc3: mmc@1c12000 { ...

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

On 5 April 2018 at 15:10, Kalle Valo wrote: > Ulf Hansson writes: > >> On 20 March 2018 at 10:55, Kalle Valo wrote: >>> Arend van Spriel writes: >>> >> If I get it right, you mean something

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

Ulf Hansson writes: > On 20 March 2018 at 10:55, Kalle Valo wrote: >> Arend van Spriel writes: >> > If I get it right, you mean something like this: > > mmc3: mmc@1c12000 { > ... >

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

On 20 March 2018 at 10:55, Kalle Valo wrote: > Arend van Spriel writes: > If I get it right, you mean something like this: mmc3: mmc@1c12000 { ... broken-sg-support; sd-head-align = 4;

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

Arend van Spriel writes: >>> If I get it right, you mean something like this: >>> >>> mmc3: mmc@1c12000 { >>> ... >>> broken-sg-support; >>> sd-head-align = 4; >>> sd-sgentry-align = 512; >>> >>> brcmf: wifi@1 { >>>

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

Arend, Agreed. Let's dismiss these patches. Now I'm curious if I can get the information about DMA SG limitations from MMC layer, I'll try to figure out something. BTW, my specific setup (with default alignments) triggers kernel panic (I see brcm_* in backtrace). It's better if I create separate

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

On 3/20/2018 8:58 AM, Alexey Roslyakov wrote: Arend, Also I am not sure if the broken-sg-support is still needed. We added that for omap_hsmmc, but that has since changed to scatter-gather emulation so it might not be needed anymore. I can confirm it doesn't impact wifi performance in case

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

Arend, >Also I am not sure if the broken-sg-support is still needed. We added that for >omap_hsmmc, but that has since changed to scatter-gather emulation so it might >not be needed anymore. I can confirm it doesn't impact wifi performance in case of rk3288+ap6335. But I still have to set

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

Arend, I use RK3288-firefly, bcm4339 (ap6335). Regards, Alex On 20 March 2018 at 06:16, Arend van Spriel wrote: > + Uffe > > On 3/19/2018 6:55 PM, Florian Fainelli wrote: >> >> On 03/19/2018 07:10 AM, Alexey Roslyakov wrote: >>> >>> Hi Arend, >>> I appreciate

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

+ Uffe On 3/19/2018 6:55 PM, Florian Fainelli wrote: On 03/19/2018 07:10 AM, Alexey Roslyakov wrote: Hi Arend, I appreciate your response. In my opinion, it has nothing to do with SDIO host, because it defines "quirks" in the driver itself. It is not clear to me from your patch series

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

On 03/19/2018 07:10 AM, Alexey Roslyakov wrote: > Hi Arend, > I appreciate your response. In my opinion, it has nothing to do with > SDIO host, because it defines "quirks" in the driver itself. It is not clear to me from your patch series whether the problem is that: - the SDIO device has a

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

Hi Arend, I appreciate your response. In my opinion, it has nothing to do with SDIO host, because it defines "quirks" in the driver itself. If I get it right, you mean something like this: mmc3: mmc@1c12000 { ... broken-sg-support; sd-head-align = 4; sd-sgentry-align =

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

On 3/19/2018 2:40 AM, Alexey Roslyakov wrote: In case if the host has higher align requirements for SG items, allow setting device-specific aligns for scatterlist items. Signed-off-by: Alexey Roslyakov ---

[PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

In case if the host has higher align requirements for SG items, allow setting device-specific aligns for scatterlist items. Signed-off-by: Alexey Roslyakov --- Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt | 5 + 1 file changed, 5