Re: [PATCH net-next v3] wireless-drivers: rtnetlink wifi simulation device

2018-11-20 Thread Cody Schuffelen
On Tue, Oct 9, 2018 at 1:25 AM Johannes Berg wrote: > > On Thu, 2018-10-04 at 12:59 -0700, Cody Schuffelen wrote: > > > > I wasn't completely clear on whether I should change the title (net-next > > to mac80211-next) so I left it as is for v3 to try to keep the patchwork > > series together. > > Y

Re: [PATCH net-next v3] wireless-drivers: rtnetlink wifi simulation device

2018-11-20 Thread Cody Schuffelen
> 1. Do not EVER submit HTML mails, mailing lists will automatically >reject them. So your mail didn't reach the lists and I only got it >because I was in the Cc field. I apologize, my mistake. > 2. Do not top post, it's really annoying: > > > https://wireless.wiki.kernel.org/en/devel

Re: [PATCH net-next v3] wireless-drivers: rtnetlink wifi simulation device

2018-11-20 Thread Cody Schuffelen
> I already said in v2 that you should not mark this for net-next as this > goes to mac80211-next (if it gets accepted), now you are just > unnecessarily confusing people. My fault, I misunderstood. The next version will be named correctly. The new version is uploaded here: https://lkml.org/lkml/

Re: [PATCH net-next v3] wireless-drivers: rtnetlink wifi simulation device

2018-11-20 Thread Cody Schuffelen
> > + informed_bss = > > + cfg80211_inform_bss_data(wiphy, &mock_inform_bss, > > +CFG80211_BSS_FTYPE_PRESP, > > +fake_router_bssid, > > +mock_inform_bss.bootti

Re: [PATCH net-next v3] wireless-drivers: rtnetlink wifi simulation device

2018-10-09 Thread Johannes Berg
On Thu, 2018-10-04 at 12:59 -0700, Cody Schuffelen wrote: > > I wasn't completely clear on whether I should change the title (net-next > to mac80211-next) so I left it as is for v3 to try to keep the patchwork > series together. You can/should change it - patchwork doesn't really track this at al

Re: [PATCH net-next v3] wireless-drivers: rtnetlink wifi simulation device

2018-10-08 Thread Sergey Matyukevich
> > Hi Cody, > > > >> drivers/net/wireless/Kconfig | 7 + > >> drivers/net/wireless/Makefile| 2 + > >> drivers/net/wireless/virt_wifi.c | 618 +++ > >> 3 files changed, 627 insertions(+) > >> create mode 100644 drivers/net/wireless/virt_wifi.c > > > > I di

Re: [PATCH net-next v3] wireless-drivers: rtnetlink wifi simulation device

2018-10-06 Thread Kalle Valo
Cody Schuffelen writes: > Thanks for the comments! I will work on incorporating the suggested > changes. Few important remarks: 1. Do not EVER submit HTML mails, mailing lists will automatically reject them. So your mail didn't reach the lists and I only got it because I was in the Cc fie

Re: [PATCH net-next v3] wireless-drivers: rtnetlink wifi simulation device

2018-10-06 Thread Kalle Valo
Cody Schuffelen writes: > This device takes over an existing network device and produces a > new one that appears like a wireless connection, returning enough canned > responses to nl80211 to satisfy a standard connection manager. If > necessary, it can also be set up one step removed from an exi

Re: [PATCH net-next v3] wireless-drivers: rtnetlink wifi simulation device

2018-10-05 Thread Joel Fernandes
On Fri, Oct 5, 2018 at 2:05 PM, Joel Fernandes wrote: > On Fri, Oct 5, 2018 at 7:33 AM, Sergey Matyukevich > wrote: >> Hi Cody, >> >>> drivers/net/wireless/Kconfig | 7 + >>> drivers/net/wireless/Makefile| 2 + >>> drivers/net/wireless/virt_wifi.c | 618 ++

Re: [PATCH net-next v3] wireless-drivers: rtnetlink wifi simulation device

2018-10-05 Thread Joel Fernandes
On Fri, Oct 5, 2018 at 7:33 AM, Sergey Matyukevich wrote: > Hi Cody, > >> drivers/net/wireless/Kconfig | 7 + >> drivers/net/wireless/Makefile| 2 + >> drivers/net/wireless/virt_wifi.c | 618 +++ >> 3 files changed, 627 insertions(+) >> create mode 100644

Re: [PATCH net-next v3] wireless-drivers: rtnetlink wifi simulation device

2018-10-05 Thread Sergey Matyukevich
Hi Cody, > drivers/net/wireless/Kconfig | 7 + > drivers/net/wireless/Makefile| 2 + > drivers/net/wireless/virt_wifi.c | 618 +++ > 3 files changed, 627 insertions(+) > create mode 100644 drivers/net/wireless/virt_wifi.c I did a quick check of your patch

[PATCH net-next v3] wireless-drivers: rtnetlink wifi simulation device

2018-10-04 Thread Cody Schuffelen
This device takes over an existing network device and produces a new one that appears like a wireless connection, returning enough canned responses to nl80211 to satisfy a standard connection manager. If necessary, it can also be set up one step removed from an existing network device, such as thro