Re: [PATCH v2] mac80211: fix A-MSDU outer SA/DA

2016-10-12 Thread michael-dev
Am 12.10.2016 14:25, schrieb Johannes Berg: So, I actually think my first instinct that you were erroneously changing the inner header *was* right. You're right. Seems like this code should be inserted towards the end of ieee80211_amsdu_aggregate() instead, where it's adding the RFC 1042 head

Re: [PATCH v2] mac80211: fix A-MSDU outer SA/DA

2016-10-12 Thread Johannes Berg
On Wed, 2016-10-12 at 12:57 +0200, Michael Braun wrote: > According to IEEE 802.11-2012 section 8.3.2 table 8-19, the outer > SA/DA of A-MSDU frames need to be changed depending on FromDS/ToDS > values. actually ... >   struct ieee80211_hdr *hdr; 802.11 header > - struct ethhdr amsdu_hd

[PATCH v2] mac80211: fix A-MSDU outer SA/DA

2016-10-12 Thread Michael Braun
According to IEEE 802.11-2012 section 8.3.2 table 8-19, the outer SA/DA of A-MSDU frames need to be changed depending on FromDS/ToDS values. Signed-off-by: Michael Braun -- v2: - avoid the extra write to amsdu_hdr - avoid copy of asmdu_hdr into skb, use ptr instead --- net/mac80211/tx.c | 45