Re: [PATCH v2] mac80211_hwsim: don't use WQ_MEM_RECLAIM

2018-01-26 Thread Benjamin Beichler
Hi, Am 26.01.2018 um 16:05 schrieb Tejun Heo: > Hello, > > On Fri, Jan 26, 2018 at 09:08:02AM +0100, Johannes Berg wrote: >> Not that you mention it ... Honestly though, wifi connections break all >> the time, so not sure you'd really want that. But anyway, that's what >> we have. > I'd be a lot h

Re: [PATCH v2] mac80211_hwsim: don't use WQ_MEM_RECLAIM

2018-01-26 Thread Tejun Heo
Hello, On Fri, Jan 26, 2018 at 09:08:02AM +0100, Johannes Berg wrote: > Not that you mention it ... Honestly though, wifi connections break all > the time, so not sure you'd really want that. But anyway, that's what > we have. I'd be a lot happier to remove WQ_MEM_RECLAIM from wireless drivers to

Re: [PATCH v2] mac80211_hwsim: don't use WQ_MEM_RECLAIM

2018-01-26 Thread Johannes Berg
On Thu, 2018-01-25 at 14:26 -0800, Tejun Heo wrote: > Yeah, that came up a couple years ago. IIRC, there wasn't a definite > answer but the sentiment seemed that things like nfs over wireless > should probably considered. No idea how serious that concern is. Not that you mention it ... Honestly

Re: [PATCH v2] mac80211_hwsim: don't use WQ_MEM_RECLAIM

2018-01-25 Thread Tejun Heo
Hello, On Thu, Jan 25, 2018 at 10:01:26PM +0100, Johannes Berg wrote: > I guess we should just ask Tejun :-) > > Tejun, the problem was a report that a WQ_MEM_RECLAIM workqueue is > flushing another that isn't, and it turns out that lots of wireless > drivers are using WQ_MEM_RECLAIM for some rea

Re: [PATCH v2] mac80211_hwsim: don't use WQ_MEM_RECLAIM

2018-01-25 Thread Johannes Berg
I guess we should just ask Tejun :-) Tejun, the problem was a report that a WQ_MEM_RECLAIM workqueue is flushing another that isn't, and it turns out that lots of wireless drivers are using WQ_MEM_RECLAIM for some reason. Arend said: > > > > Maybe a hint in the documentation, that a work item on

Re: [PATCH v2] mac80211_hwsim: don't use WQ_MEM_RECLAIM

2018-01-25 Thread Arend van Spriel
resending as it included html and got blocked from the list. On 1/25/2018 7:21 PM, Arend Van Spriel wrote: Op 24 jan. 2018 11:46 schreef "Johannes Berg" mailto:johan...@sipsolutions.net>>: > > On Wed, 2018-01-24 at 10:39 +0100, Benjamin Beichler wrote: > > > sorry for introducing that error,

Re: [PATCH v2] mac80211_hwsim: don't use WQ_MEM_RECLAIM

2018-01-24 Thread Johannes Berg
On Wed, 2018-01-24 at 10:39 +0100, Benjamin Beichler wrote: > sorry for introducing that error, but I'm a bit confused by the > workqueue documentation. > My assumption was, that deleting hwsim radios is reclaiming memory, and > since this queue does nothing else it would save/necessary to set thi

Re: [PATCH v2] mac80211_hwsim: don't use WQ_MEM_RECLAIM

2018-01-24 Thread Benjamin Beichler
Hi Johannes, sorry for introducing that error, but I'm a bit confused by the workqueue documentation. My assumption was, that deleting hwsim radios is reclaiming memory, and since this queue does nothing else it would save/necessary to set this flag. Maybe a hint in the documentation, that a work

[PATCH v2] mac80211_hwsim: don't use WQ_MEM_RECLAIM

2018-01-23 Thread Johannes Berg
From: Johannes Berg We're obviously not part of a memory reclaim path, so don't set the flag. This also causes a warning in check_flush_dependency() since we end up in a code path that flushes a non-reclaim workqueue, and we shouldn't do that if we were really part of reclaim. Reported-by: syzb