Re: [PATCH v2 06/10] nl80211: Various checkpatch.pl spacing fixes

2016-05-30 Thread Julian Calaby
Hi All, On Mon, May 30, 2016 at 12:53 PM, Kirtika Ruchandani wrote: > This patch fixes the following spacing issues reported > by checkpatch.pl - > - space preferred around that > - no space needed after cast. > - Alignment should match open parenthesis > - suspect

Re: [PATCH v2 06/10] nl80211: Various checkpatch.pl spacing fixes

2016-05-30 Thread Julian Calaby
Hi Kirtika, On Mon, May 30, 2016 at 4:04 PM, Kirtika Ruchandani wrote: >> Adding the brackets around the & expression doesn't look spacing >> related to me. What's the exact warning this is fixing? > > From the commit message - "This patch also contains two hunks to

Re: [PATCH v2 06/10] nl80211: Various checkpatch.pl spacing fixes

2016-05-30 Thread Kirtika Ruchandani
> Adding the brackets around the & expression doesn't look spacing > related to me. What's the exact warning this is fixing? >From the commit message - "This patch also contains two hunks to fix 'line over 80 characters', that are spacing related". This is the second hunk, the first being the

[PATCH v2 06/10] nl80211: Various checkpatch.pl spacing fixes

2016-05-29 Thread Kirtika Ruchandani
This patch fixes the following spacing issues reported by checkpatch.pl - - space preferred around that - no space needed after cast. - Alignment should match open parenthesis - suspect code indent for conditional statements - Statements should start on a tabstop This patch also contains two