[PATCH v2 1/2] cfg80211: Add support to set tx power for a station associated

2017-01-31 Thread Ashok Raj Nagarajan
This patch adds support to set transmit power setting type and transmit power level attributes to NL80211_CMD_SET_STATION in order to facilitate adjusting the transmit power level of a station associated to the AP. The added attributes allow selection of automatic and limited transmit power level,

Re: [PATCH v2 1/2] cfg80211: Add support to set tx power for a station associated

2017-01-31 Thread Ben Greear
On 01/31/2017 10:41 AM, Ashok Raj Nagarajan wrote: This patch adds support to set transmit power setting type and transmit power level attributes to NL80211_CMD_SET_STATION in order to facilitate adjusting the transmit power level of a station associated to the AP. The added attributes allow sel

Re: [PATCH v2 1/2] cfg80211: Add support to set tx power for a station associated

2017-02-01 Thread Ashok Raj Nagarajan
On 2017-02-01 00:36, Ben Greear wrote: On 01/31/2017 10:41 AM, Ashok Raj Nagarajan wrote: This patch adds support to set transmit power setting type and transmit power level attributes to NL80211_CMD_SET_STATION in order to facilitate adjusting the transmit power level of a station associated

Re: [PATCH v2 1/2] cfg80211: Add support to set tx power for a station associated

2017-02-01 Thread Ben Greear
On 02/01/2017 09:27 AM, Ashok Raj Nagarajan wrote: +static int nl80211_parse_sta_txpower_setting(struct genl_info *info, + struct station_parameters *params) +{ +struct cfg80211_registered_device *rdev = info->user_ptr[0]; +enum nl80211_tx_power_setting type; +

Re: [PATCH v2 1/2] cfg80211: Add support to set tx power for a station associated

2017-02-01 Thread Ashok Raj Nagarajan
On 2017-02-01 23:06, Ben Greear wrote: On 02/01/2017 09:27 AM, Ashok Raj Nagarajan wrote: +static int nl80211_parse_sta_txpower_setting(struct genl_info *info, + struct station_parameters *params) +{ +struct cfg80211_registered_device *rdev = info->user_ptr[0]; +

Re: [PATCH v2 1/2] cfg80211: Add support to set tx power for a station associated

2017-02-01 Thread Ben Greear
On 02/01/2017 09:57 AM, Ashok Raj Nagarajan wrote: On 2017-02-01 23:06, Ben Greear wrote: On 02/01/2017 09:27 AM, Ashok Raj Nagarajan wrote: +static int nl80211_parse_sta_txpower_setting(struct genl_info *info, + struct station_parameters *params) +{ +struct cfg8021

Re: [PATCH v2 1/2] cfg80211: Add support to set tx power for a station associated

2017-02-06 Thread Johannes Berg
> You use value '0' to mean set to default values, as far as I can > tell. I think you're confusing the internal API and the userspace API - at a userspace level you have to set NL80211_ATTR_STA_TX_POWER_SETTING to NL80211_TX_POWER_AUTOMATIC to revert back to defaults, no? For perfect backwards