Re: [PATCH v2 1/3] ath10k: don't enable interrupts for the diagnostic window

2014-09-24 Thread Kalle Valo
Michal Kazior writes: > On 23 September 2014 16:32, Kalle Valo wrote: > [...] >> - for (ce_id = 0; ce_id < CE_COUNT; ce_id++) >> + /* Skip the last copy engine, CE7 the diagnostic window, as that >> +* uses polling and isn't initialized for interrupts. */ > > Comment style :-

Re: [PATCH v2 1/3] ath10k: don't enable interrupts for the diagnostic window

2014-09-23 Thread Michal Kazior
On 23 September 2014 16:32, Kalle Valo wrote: [...] > - for (ce_id = 0; ce_id < CE_COUNT; ce_id++) > + /* Skip the last copy engine, CE7 the diagnostic window, as that > +* uses polling and isn't initialized for interrupts. */ Comment style :-) MichaƂ -- To unsubscribe from

Re: [PATCH v2 1/3] ath10k: don't enable interrupts for the diagnostic window

2014-09-23 Thread Kalle Valo
Hi, I forgot add --edit-cover to stg. So here's the cover letter :) ath10k: export calibration data to user space here's a small patchset exporting firmware calibration data to user space. This makes it easier to debug various calibration data related problems. Please comment. v2: * never unm

[PATCH v2 1/3] ath10k: don't enable interrupts for the diagnostic window

2014-09-23 Thread Kalle Valo
The diagnostic window (CE7) uses polling and is not initiliased to retrieve interrupts so disable interrupts altogether for CE7. Otherwise ath10k crashes when using the diagnostic window while the firmware is running due to NULL dereference and polling reads timeout. Signed-off-by: Kalle Valo ---