Re: [PATCH v2 2/2] cfg80211: Add support to sched scan to report better BSSs

2017-01-04 Thread Johannes Berg
> Also I don't see the array issue. @relative_rssi_5g_pref with s8 > value seems same as @rssi_adjust with (band=5g, s8 value) packed > together. Or am I missing something here. Jouni is arguing that if you can specify which band to adjust, you might want to adjust more than one band - and need a

Re: [PATCH v2 2/2] cfg80211: Add support to sched scan to report better BSSs

2017-01-04 Thread Johannes Berg
On Tue, 2016-12-20 at 20:52 +, Malinen, Jouni wrote: > > I think between that (unless we add that, we could technically > > extend flag attributes to allow them being an int as well, or add a > > new one) and the fact that the device may not support different > > relative RSSI matches in diffe

Re: [PATCH v2 2/2] cfg80211: Add support to sched scan to report better BSSs

2016-12-21 Thread Arend Van Spriel
On 20-12-2016 21:52, Malinen, Jouni wrote: > On Fri, Dec 16, 2016 at 10:56:51AM +0100, Johannes Berg wrote: >> On Thu, 2016-12-15 at 11:06 +, Malinen, Jouni wrote: >>> Maybe the nl80211.h description was not clear enough, but the >>> comments in cfg80211.h should be quite clear on how this was

Re: [PATCH v2 2/2] cfg80211: Add support to sched scan to report better BSSs

2016-12-20 Thread Malinen, Jouni
On Fri, Dec 16, 2016 at 10:56:51AM +0100, Johannes Berg wrote: > On Thu, 2016-12-15 at 11:06 +, Malinen, Jouni wrote: > > Maybe the nl80211.h description was not clear enough, but the > > comments in cfg80211.h should be quite clear on how this was designed > > to work at the implementation lev

Re: [PATCH v2 2/2] cfg80211: Add support to sched scan to report better BSSs

2016-12-16 Thread Johannes Berg
On Thu, 2016-12-15 at 11:06 +, Malinen, Jouni wrote: > On Tue, Dec 13, 2016 at 04:56:55PM +0100, Johannes Berg wrote: > > Regarding reusing attributes, we have (for the BSS selection thing) > > the attribute NL80211_BSS_SELECT_ATTR_RSSI_ADJUST, which is really > > quite similar to your > > new 

Re: [PATCH v2 2/2] cfg80211: Add support to sched scan to report better BSSs

2016-12-15 Thread Malinen, Jouni
On Tue, Dec 13, 2016 at 04:56:55PM +0100, Johannes Berg wrote: > Regarding reusing attributes, we have (for the BSS selection thing) the > attribute NL80211_BSS_SELECT_ATTR_RSSI_ADJUST, which is really quite > similar to your new NL80211_ATTR_SCHED_SCAN_RELATIVE_RSSI_5G_PREF since > while connected

Re: [PATCH v2 2/2] cfg80211: Add support to sched scan to report better BSSs

2016-12-13 Thread Johannes Berg
Ok... this is getting complicated :) Regarding reusing attributes, we have (for the BSS selection thing) the attribute NL80211_BSS_SELECT_ATTR_RSSI_ADJUST, which is really quite similar to your new NL80211_ATTR_SCHED_SCAN_RELATIVE_RSSI_5G_PREF since while connected (which BSS_SELECT_ATTR_* assumes

Re: [PATCH v2 2/2] cfg80211: Add support to sched scan to report better BSSs

2016-12-08 Thread Arend Van Spriel
On 8-12-2016 18:52, Malinen, Jouni wrote: > On Wed, Dec 07, 2016 at 09:03:23PM +0100, Arend Van Spriel wrote: >> On 7-12-2016 10:33, Vamsi, Krishna wrote: -Original Message- From: Johannes Berg [mailto:johan...@sipsolutions.net] >>> What about Arend's comment regarding this f

Re: [PATCH v2 2/2] cfg80211: Add support to sched scan to report better BSSs

2016-12-08 Thread Malinen, Jouni
On Wed, Dec 07, 2016 at 09:03:23PM +0100, Arend Van Spriel wrote: > On 7-12-2016 10:33, Vamsi, Krishna wrote: > >> -Original Message- > >> From: Johannes Berg [mailto:johan...@sipsolutions.net] > > > >> What about Arend's comment regarding this functionality overlapping with > >> the > >>

Re: [PATCH v2 2/2] cfg80211: Add support to sched scan to report better BSSs

2016-12-07 Thread Arend Van Spriel
On 2-12-2016 22:59, Jouni Malinen wrote: > From: vamsi krishna > > Enhance sched scan to support option of finding a better BSS while in > connected state. Firmware scans the medium and reports when it finds a > known BSS which has better RSSI than the current connected BSS. New > attributes to s

Re: [PATCH v2 2/2] cfg80211: Add support to sched scan to report better BSSs

2016-12-07 Thread Arend Van Spriel
On 7-12-2016 10:33, Vamsi, Krishna wrote: >> -Original Message- >> From: Johannes Berg [mailto:johan...@sipsolutions.net] > >> What about Arend's comment regarding this functionality overlapping with the >> BSS selection offload configuration? >> >> Do you think there's any ability to shar

RE: [PATCH v2 2/2] cfg80211: Add support to sched scan to report better BSSs

2016-12-07 Thread Vamsi, Krishna
> -Original Message- > From: Johannes Berg [mailto:johan...@sipsolutions.net] > What about Arend's comment regarding this functionality overlapping with the > BSS selection offload configuration? > > Do you think there's any ability to share attributes/functionality? Hi Johannes, I thin

Re: [PATCH v2 2/2] cfg80211: Add support to sched scan to report better BSSs

2016-12-07 Thread Johannes Berg
> v2: address comments from Luca, Arend, and Johannes What about Arend's comment regarding this functionality overlapping with the BSS selection offload configuration? Do you think there's any ability to share attributes/functionality? johannes

[PATCH v2 2/2] cfg80211: Add support to sched scan to report better BSSs

2016-12-02 Thread Jouni Malinen
From: vamsi krishna Enhance sched scan to support option of finding a better BSS while in connected state. Firmware scans the medium and reports when it finds a known BSS which has better RSSI than the current connected BSS. New attributes to specify the relative RSSI (compared to the current BSS