Re: [PATCH v2 23/23] ath9k: Do not start BA when scanning

2014-10-20 Thread Johannes Berg
On Mon, 2014-10-20 at 15:09 +0530, Sujith Manoharan wrote: > Johannes Berg wrote: > > If it's a mac80211 race, wouldn't it make sense to fix it in mac80211? > > Yes, definitely. :-) > > But, we also ran into issues where starting a BA session > when HW scan was in progress (with MCC enabled) caus

Re: [PATCH v2 23/23] ath9k: Do not start BA when scanning

2014-10-20 Thread Sujith Manoharan
Johannes Berg wrote: > If it's a mac80211 race, wouldn't it make sense to fix it in mac80211? Yes, definitely. :-) But, we also ran into issues where starting a BA session when HW scan was in progress (with MCC enabled) caused connectivity problems, hence this fix in ath9k. Regarding the BA race

Re: [PATCH v2 23/23] ath9k: Do not start BA when scanning

2014-10-20 Thread Johannes Berg
On Fri, 2014-10-17 at 07:40 +0530, Sujith Manoharan wrote: > From: Sujith Manoharan > > mac80211 currently has a race which can be hit > with this sequence: If it's a mac80211 race, wouldn't it make sense to fix it in mac80211? johannes -- To unsubscribe from this list: send the line "unsubscr

[PATCH v2 23/23] ath9k: Do not start BA when scanning

2014-10-16 Thread Sujith Manoharan
From: Sujith Manoharan mac80211 currently has a race which can be hit with this sequence: * Start a scan operation. * TX BA is initiated by ieee80211_start_tx_ba_session(). * Driver sets up internal state and calls ieee80211_start_tx_ba_cb_irqsafe(). * mac80211 adds a packet to sdata->skb_queu