[PATCH v3 4/4] rt2800: fix registers init for MT7620

2018-10-09 Thread Stanislaw Gruszka
There is dupliceted 'if (rt2x00_rt(rt2x00dev, RT6352))' entry that couses we do not perform proper register initaliztion for RT6352 (MT7620 SOCs). Reported-by: Tomislav Požega Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 3 +-- 1 file changed, 1 insertio

Re: [PATCH v3 4/4] rt2800: fix registers init for MT7620

2018-10-09 Thread Tom Psyborg
On 09/10/2018, Stanislaw Gruszka wrote: > There is dupliceted 'if (rt2x00_rt(rt2x00dev, RT6352))' entry that couses > we do not perform proper register initaliztion for RT6352 (MT7620 SOCs). > > Reported-by: Tomislav Požega > Signed-off-by: Stanislaw Gruszka > --- > drivers/net/wireless/ralink/

Re: [PATCH v3 4/4] rt2800: fix registers init for MT7620

2018-10-10 Thread Stanislaw Gruszka
On Wed, Oct 10, 2018 at 01:27:31AM +0200, Tom Psyborg wrote: > On 09/10/2018, Stanislaw Gruszka wrote: > > There is dupliceted 'if (rt2x00_rt(rt2x00dev, RT6352))' entry that couses > > we do not perform proper register initaliztion for RT6352 (MT7620 SOCs). > > > > Reported-by: Tomislav Požega >

Re: [PATCH v3 4/4] rt2800: fix registers init for MT7620

2018-10-10 Thread Daniel Golle
Hi Stanislaw, On Wed, Oct 10, 2018 at 09:14:52AM +0200, Stanislaw Gruszka wrote: > On Wed, Oct 10, 2018 at 01:27:31AM +0200, Tom Psyborg wrote: > > On 09/10/2018, Stanislaw Gruszka wrote: > > > There is dupliceted 'if (rt2x00_rt(rt2x00dev, RT6352))' entry that couses > > > we do not perform prope

Re: [PATCH v3 4/4] rt2800: fix registers init for MT7620

2018-10-10 Thread Stanislaw Gruszka
Hello On Wed, Oct 10, 2018 at 02:06:58PM +0200, Daniel Golle wrote: > > > https://github.com/psyborg55/linux/commit/24b46d482590a87553df1de0b5c8032f363cb7cf > > > ? > > > > > > using this code to determine 7620 soc > > > > > > if (rt == RT5390 && rt2x00_is_soc(rt2x00dev)) > > > rt =

Re: [PATCH v3 4/4] rt2800: fix registers init for MT7620

2018-10-10 Thread Tom Psyborg
case 1: } else if (rt2x00_rt(rt2x00dev, RT5390) || rt2x00_rt(rt2x00dev, RT5392)) { rt2800_register_write(rt2x00dev, TX_SW_CFG0, 0x0404); rt2800_register_write(rt2x00dev, TX_SW_CFG1, 0x00080606); rt2800_register_write(rt

Re: [PATCH v3 4/4] rt2800: fix registers init for MT7620

2018-10-10 Thread Stanislaw Gruszka
On Wed, Oct 10, 2018 at 04:11:12PM +0200, Tom Psyborg wrote: > case 1: > > } else if (rt2x00_rt(rt2x00dev, RT5390) || > rt2x00_rt(rt2x00dev, RT5392)) { > rt2800_register_write(rt2x00dev, TX_SW_CFG0, 0x0404); > rt2800_register_write(rt2x00dev,

Re: [PATCH v3 4/4] rt2800: fix registers init for MT7620

2018-10-10 Thread Tom Psyborg
ok, that is strange. do you see any performance differences without TX_SW_CFG regs? iperf test is a good pointer. this was a problem on xiaomi mini with old DD trunk builds on 4.4 kernel and LEDE builds from last year. i ain't got no chance to try this on 18.06. which device you tried this on? if

Re: [PATCH v3 4/4] rt2800: fix registers init for MT7620

2018-10-11 Thread Stanislaw Gruszka
On Wed, Oct 10, 2018 at 10:03:12PM +0200, Tom Psyborg wrote: > ok, that is strange. do you see any performance differences without > TX_SW_CFG regs? iperf test is a good pointer. > > this was a problem on xiaomi mini with old DD trunk builds on 4.4 > kernel and LEDE builds from last year. i ain't

Re: [PATCH v3 4/4] rt2800: fix registers init for MT7620

2018-10-11 Thread Tom Psyborg
so this is RX test where I assume your 7265 card is sending data. is that HT20 or HT40 mode and do you get regression on TX too? can you try same case 2 test but with registers set to: TX_SW_CFG0, 0x0401 TX_SW_CFG1, 0x000C TX_SW_CFG2, 0x (or 0x000C0408) did you ever notice any tx

Re: [PATCH v3 4/4] rt2800: fix registers init for MT7620

2018-10-12 Thread Stanislaw Gruszka
On Thu, Oct 11, 2018 at 02:39:25PM +0200, Tom Psyborg wrote: > so this is RX test where I assume your 7265 card is sending data. is > that HT20 or HT40 mode and do you get regression on TX too? > > can you try same case 2 test but with registers set to: > > TX_SW_CFG0, 0x0401 > TX_SW_CFG1, 0x