Re: Re: [PATCH v4 1/3] mwifiex: refactor device dump code to make it generic for usb interface

2017-12-06 Thread Xinming Hu
napathi Bhat ; Ellie Reeves > > Subject: [EXT] Re: [PATCH v4 1/3] mwifiex: refactor device dump code to make > it > generic for usb interface > > External Email > > -- > Hi, > > On Mon, Dec 04

RE: [EXT] Re: [PATCH v4 1/3] mwifiex: refactor device dump code to make it generic for usb interface

2017-12-06 Thread Xinming Hu
napathi Bhat ; Ellie Reeves > > Subject: [EXT] Re: [PATCH v4 1/3] mwifiex: refactor device dump code to make > it > generic for usb interface > > External Email > > -- > Hi, > > On Mon, Dec 04

Re: [PATCH v4 1/3] mwifiex: refactor device dump code to make it generic for usb interface

2017-12-05 Thread Brian Norris
Hi, On Mon, Dec 04, 2017 at 08:18:42PM +0800, Xinming Hu wrote: > This patch refactor current device dump code to make it generic > for subsequent implementation on usb interface. I still think you're making the spaghetti worse. I only have a few specific suggestions for improving your spaghetti

[PATCH v4 1/3] mwifiex: refactor device dump code to make it generic for usb interface

2017-12-04 Thread Xinming Hu
This patch refactor current device dump code to make it generic for subsequent implementation on usb interface. Signed-off-by: Xinming Hu Signed-off-by: Cathy Luo Signed-off-by: Ganapathi Bhat --- v2: Addressed below review comments from Brian Norris a) use new API timer_setup/from_timer.