Re: [PATCH v4 6/8] ath10k: introduce wmi ops

2014-12-07 Thread Kalle Valo
Michal Kazior writes: > On 3 December 2014 at 09:10, Kalle Valo wrote: > [...] >> int ath10k_wmi_attach(struct ath10k *ar) >> { >> - if (test_bit(ATH10K_FW_FEATURE_WMI_10X, ar->fw_features)) { >> - if (test_bit(ATH10K_FW_FEATURE_WMI_10_2, ar->fw_features)) >> -

Re: [PATCH v4 6/8] ath10k: introduce wmi ops

2014-12-07 Thread Kalle Valo
Michal Kazior writes: > On 3 December 2014 at 09:10, Kalle Valo wrote: > >> --- a/drivers/net/wireless/ath/ath10k/testmode.c >> +++ b/drivers/net/wireless/ath/ath10k/testmode.c >> @@ -187,13 +187,14 @@ static int ath10k_tm_cmd_utf_start(struct ath10k *ar, >> struct nlattr *tb[]) >> >> m

Re: [PATCH v4 6/8] ath10k: introduce wmi ops

2014-12-07 Thread Michal Kazior
On 3 December 2014 at 09:10, Kalle Valo wrote: [...] > int ath10k_wmi_attach(struct ath10k *ar) > { > - if (test_bit(ATH10K_FW_FEATURE_WMI_10X, ar->fw_features)) { > - if (test_bit(ATH10K_FW_FEATURE_WMI_10_2, ar->fw_features)) > - ar->wmi.cmd = &wmi_10_2

Re: [PATCH v4 6/8] ath10k: introduce wmi ops

2014-12-03 Thread Michal Kazior
On 3 December 2014 at 09:10, Kalle Valo wrote: [...] > diff --git a/drivers/net/wireless/ath/ath10k/core.h > b/drivers/net/wireless/ath/ath10k/core.h > index e0999cdaa18f..8c839f68beac 100644 > --- a/drivers/net/wireless/ath/ath10k/core.h > +++ b/drivers/net/wireless/ath/ath10k/core.h [...] > @@

[PATCH v4 6/8] ath10k: introduce wmi ops

2014-12-03 Thread Kalle Valo
From: Michal Kazior Since the 10.x fw branch support was introduced it became apparent ath10k will need to be able to deal with different fw ABIs eventually. The patch creates an abstraction for dealing with command and event structures across different ABIs and mostly gets rid of the ATH10K_FW_