Re: [PATCH v5] Add new mac80211 driver mwlwifi.

Kalle Valo writes: > Chor Teck Law writes: > >> But for different generation of future chipsets/new technology, when >> the hardware no longer permit us to use same driver, we will have to >> re-evaluate our options. We cannot guarantee something way out

RE: [PATCH v5] Add new mac80211 driver mwlwifi.

> > Kalle Valo writes: > > > Chor Teck Law writes: > > > >> But for different generation of future chipsets/new technology, when > >> the hardware no longer permit us to use same driver, we will have to > >> re-evaluate our options. We cannot guarantee

RE: [PATCH v5] Add new mac80211 driver mwlwifi.

Hi Kalle, > -Original Message- > From: Kalle Valo [mailto:kv...@codeaurora.org] > Sent: Monday, September 07, 2015 4:20 AM > > > Chor Teck Law writes: > > >> On Tuesday 04 Aug 2015 à 20:02:23 (+0300), Kalle Valo wrote: > >> > >> > I haven't looked at the driver

Re: [PATCH v5] Add new mac80211 driver mwlwifi.

Chor Teck Law writes: >> On Tuesday 04 Aug 2015 à 20:02:23 (+0300), Kalle Valo wrote: >> >> > I haven't looked at the driver myself yet. Do you have any estimates >> > how much duplication there is? >> > > I do think that someone interested in this thread should compare the

Re: [PATCH v5] Add new mac80211 driver mwlwifi.

Maxime Bizon writes: > but from my POV, your pattern is: build new chipset, obsolete previous > chipset, fork current firmware, make uncompatible changes to both > firmware & host driver to accomodate new chipset peculiarities. > > and eventually, if a customer requests a

RE: [PATCH v5] Add new mac80211 driver mwlwifi.

On Tuesday 04 Aug 2015 à 20:02:23 (+0300), Kalle Valo wrote: I haven't looked at the driver myself yet. Do you have any estimates how much duplication there is? I do think that someone interested in this thread should compare the two drivers to decide if they want to accept mwlwifi

Re: [PATCH v5] Add new mac80211 driver mwlwifi.

On Wednesday 05 Aug 2015 à 08:39:28 (+), Chor Teck Law wrote: Last words, The mwl8k series had its history, since 2009 with the Topdog series (Beyond our scope to comment). The mwlwifi have been developed over past year or so for the Avastar AP chips, being incorrect, mwl8k also support

RE: [PATCH v5] Add new mac80211 driver mwlwifi.

-Original Message- From: Maxime Bizon [mailto:mbi...@freebox.fr] Sent: Wednesday, August 05, 2015 7:22 AM On Wednesday 05 Aug 2015 à 08:39:28 (+), Chor Teck Law wrote: Last words, The mwl8k series had its history, since 2009 with the Topdog series (Beyond our scope to

Re: [PATCH v5] Add new mac80211 driver mwlwifi.

On Tuesday 04 Aug 2015 à 20:02:23 (+0300), Kalle Valo wrote: I haven't looked at the driver myself yet. Do you have any estimates how much duplication there is? ok the thing is I happen to know a bit about the chipset internals and so it's easy for me to know that having a common driver is

Re: [PATCH v5] Add new mac80211 driver mwlwifi.

On Tuesday 04 Aug 2015 à 18:11:29 (+), Chor Teck Law wrote: Hi Chor, mwl8k was a driver for chips few generations older sponsored by Marvell. We did leverage part of driver framework that is still applicable. However, for the current development, the firmware API specs, chip

RE: [PATCH v5] Add new mac80211 driver mwlwifi.

Hi Kalle, -Original Message- From: Kalle Valo [mailto:kv...@codeaurora.org] Sent: Tuesday, August 04, 2015 10:02 AM Maxime Bizon mbi...@freebox.fr writes: On Fri, 2015-07-03 at 06:10 +, David Lin wrote: Hello, The Linux driver for WRT1900AC. The work was initially

Re: [PATCH v5] Add new mac80211 driver mwlwifi.

Maxime Bizon mbi...@freebox.fr writes: On Fri, 2015-07-03 at 06:10 +, David Lin wrote: Hello, The Linux driver for WRT1900AC. The work was initially developed as part of openwrt effort and maintained on https://github.com/kaloz/mwlwifi. I see *massive* code duplication with the mwl8k

Re: [PATCH v5] Add new mac80211 driver mwlwifi.

On Fri, 2015-07-03 at 06:10 +, David Lin wrote: Hello, The Linux driver for WRT1900AC. The work was initially developed as part of openwrt effort and maintained on https://github.com/kaloz/mwlwifi. I see *massive* code duplication with the mwl8k driver. This is, I guess, not a surprise

RE: [PATCH v5] Add new mac80211 driver mwlwifi.

Johannes Berg wrote: +/* Bit definitio for MACREG_REG_A2H_INTERRUPT_CAUSE (A2HRIC) */ typo Will correct it. +/* Bit definitio for MACREG_REG_H2A_INTERRUPT_CAUSE (H2ARIC) */ same here Will correct it. +struct mwl_chip_info { + char *part_name; + char *fw_image; +};

Re: [PATCH v5] Add new mac80211 driver mwlwifi.

On Tue, Jul 7, 2015 at 3:47 AM, David Lin d...@marvell.com wrote: Jonas Gorski wrote: Hi, On Fri, Jul 3, 2015 at 8:10 AM, David Lin d...@marvell.com wrote: (snip) diff --git a/drivers/net/wireless/mwlwifi/Kconfig b/drivers/net/wireless/mwlwifi/Kconfig new file mode 100644 index

Re: [PATCH v5] Add new mac80211 driver mwlwifi.

On Tue, 07 Jul 2015 11:38:32 +0200, Jonas Gorski j...@openwrt.org wrote: snip I think it would be good to have some more precise description here (something like Marvell 88W8864/8897 PCIe driver with AP support). Will change the title from Marvell Wireless Wi-Fi driver (mwlwifi) to

Re: [PATCH v5] Add new mac80211 driver mwlwifi.

Subject: Re: [PATCH v5] Add new mac80211 driver mwlwifi. On Tue, 07 Jul 2015 11:38:32 +0200, Jonas Gorski j...@openwrt.org wrote: snip I think it would be good to have some more precise description here (something like Marvell 88W8864/8897 PCIe driver with AP support). Will change

RE: [PATCH v5] Add new mac80211 driver mwlwifi.

-Original Message- From: Imre Kaloz [mailto:ka...@openwrt.org] Sent: Tuesday, July 07, 2015 2:50 AM To: David Lin; Jonas Gorski Cc: Johannes Berg; linux-wireless@vger.kernel.org; Chor Teck Law; Pete Hsieh Subject: Re: [PATCH v5] Add new mac80211 driver mwlwifi. On Tue, 07 Jul

Re: [PATCH v5] Add new mac80211 driver mwlwifi.

On Tue, 07 Jul 2015 15:48:38 +0200, Chor Teck Law ct...@marvell.com wrote: Will change the title from Marvell Wireless Wi-Fi driver (mwlwifi) to Marvell 88W8864/88W8897 PCIe driver with AP support. As Imre pointed out, mwifiex also supports AP mode, so this is not a good description.

RE: [PATCH v5] Add new mac80211 driver mwlwifi.

-Original Message- From: Imre Kaloz [mailto:ka...@openwrt.org] Sent: Tuesday, July 07, 2015 7:36 AM To: David Lin; Jonas Gorski; Chor Teck Law Cc: Johannes Berg; linux-wireless@vger.kernel.org; Pete Hsieh Subject: Re: [PATCH v5] Add new mac80211 driver mwlwifi. On Tue, 07 Jul

RE: [PATCH v5] Add new mac80211 driver mwlwifi.

Jonas Gorski wrote: Hi, On Fri, Jul 3, 2015 at 8:10 AM, David Lin d...@marvell.com wrote: The Linux driver for WRT1900AC. The work was initially developed as part of openwrt effort and maintained on https://github.com/kaloz/mwlwifi. This is still work in progress, with 8864 chipset

Re: [PATCH v5] Add new mac80211 driver mwlwifi.

I'm not so sure about the OF thing - at least in general this seems right and many drivers are selecting OF. If that causes issues on certain platforms then perhaps those platforms should fix the issues, or the whole OF should be changed to depends on? --- /dev/null +++

Re: [PATCH v5] Add new mac80211 driver mwlwifi.

Hi, On Fri, Jul 3, 2015 at 8:10 AM, David Lin d...@marvell.com wrote: The Linux driver for WRT1900AC. The work was initially developed as part of openwrt effort and maintained on https://github.com/kaloz/mwlwifi. This is still work in progress, with 8864 chipset more mature and tested, while

Re: [PATCH v5] Add new mac80211 driver mwlwifi.

On Sun, Jul 5, 2015 at 12:33 PM, Johannes Berg johan...@sipsolutions.net wrote: I'm not so sure about the OF thing - at least in general this seems right and many drivers are selecting OF. If that causes issues on certain platforms then perhaps those platforms should fix the issues, or the

Re: [PATCH v5] Add new mac80211 driver mwlwifi.

+/* Bit definitio for MACREG_REG_A2H_INTERRUPT_CAUSE (A2HRIC) */ typo +/* Bit definitio for MACREG_REG_H2A_INTERRUPT_CAUSE (H2ARIC) */ same here +struct mwl_chip_info { + char *part_name; + char *fw_image; +}; const char *? +struct mwl_tx_hndl { + struct sk_buff