Re: [PATCH v6 1/3] nl80211: Add ATOMIC_KEY_REPLACE API

2018-08-29 Thread Johannes Berg
On Tue, 2018-08-28 at 21:02 +0200, Alexander Wetzel wrote: > My current preference is how the patch v6 is working and I'm quite sure > there is no acceptable way to trick the userspace. > Am I wrong here and we should try something different? No, you're probably right. I'll take this as it is per

Re: [PATCH v6 1/3] nl80211: Add ATOMIC_KEY_REPLACE API

2018-08-28 Thread Alexander Wetzel
Am 28.08.18 um 18:03 schrieb Johannes Berg: > On Tue, 2018-08-28 at 18:00 +0200, Alexander Wetzel wrote: > >>> If you have a flag here, why say "userspace must not" rather than just >>> outright prevent userspace from doing it? >> >> The userspace must not but currently of course is doing exactly

Re: [PATCH v6 1/3] nl80211: Add ATOMIC_KEY_REPLACE API

2018-08-28 Thread Alexander Wetzel
Am 28.08.18 um 10:47 schrieb Johannes Berg: > On Tue, 2018-08-14 at 12:42 +0200, Alexander Wetzel wrote: >> Drivers able to correctly replace a in-use key should set >> NL80211_EXT_FEATURE_ATOMIC_KEY_REPLACE to allow the userspace (e.g. >> hostapd or wpa_supplicant) to rekey PTK keys. >> >> The u

Re: [PATCH v6 1/3] nl80211: Add ATOMIC_KEY_REPLACE API

2018-08-28 Thread Johannes Berg
On Tue, 2018-08-28 at 18:00 +0200, Alexander Wetzel wrote: > > If you have a flag here, why say "userspace must not" rather than just > > outright prevent userspace from doing it? > > The userspace must not but currently of course is doing exactly that. > Enforcing the new requirement would there

Re: [PATCH v6 1/3] nl80211: Add ATOMIC_KEY_REPLACE API

2018-08-28 Thread Alexander Wetzel
Am 28.08.18 um 10:46 schrieb Johannes Berg: > On Sat, 2018-08-18 at 22:53 +0200, Alexander Wetzel wrote: > >>> This looks good to me from a userspace perspective. I will try to >>> implement support for this in iwd soon to give you a prototype to play >>> with. >> >> Sounds promising, thank you

Re: [PATCH v6 1/3] nl80211: Add ATOMIC_KEY_REPLACE API

2018-08-28 Thread Johannes Berg
On Tue, 2018-08-14 at 12:42 +0200, Alexander Wetzel wrote: > Drivers able to correctly replace a in-use key should set > NL80211_EXT_FEATURE_ATOMIC_KEY_REPLACE to allow the userspace (e.g. > hostapd or wpa_supplicant) to rekey PTK keys. > > The userspace must detect a PTK rekey attempt and only go

Re: [PATCH v6 1/3] nl80211: Add ATOMIC_KEY_REPLACE API

2018-08-28 Thread Johannes Berg
On Sat, 2018-08-18 at 22:53 +0200, Alexander Wetzel wrote: > > This looks good to me from a userspace perspective. I will try to > > implement support for this in iwd soon to give you a prototype to play > > with. > > Sounds promising, thank you! > > I'm still unsure if we really need the API c

Re: [PATCH v6 1/3] nl80211: Add ATOMIC_KEY_REPLACE API

2018-08-18 Thread Alexander Wetzel
Hi Denis Am 16.08.18 um 18:30 schrieb Denis Kenzior: > Hi Alexander, > > On 08/14/2018 05:42 AM, Alexander Wetzel wrote: >> Drivers able to correctly replace a in-use key should set >> NL80211_EXT_FEATURE_ATOMIC_KEY_REPLACE to allow the userspace (e.g. >> hostapd or wpa_supplicant) to rekey PTK k

Re: [PATCH v6 1/3] nl80211: Add ATOMIC_KEY_REPLACE API

2018-08-16 Thread Denis Kenzior
Hi Alexander, On 08/14/2018 05:42 AM, Alexander Wetzel wrote: Drivers able to correctly replace a in-use key should set NL80211_EXT_FEATURE_ATOMIC_KEY_REPLACE to allow the userspace (e.g. hostapd or wpa_supplicant) to rekey PTK keys. The userspace must detect a PTK rekey attempt and only go ahe

[PATCH v6 1/3] nl80211: Add ATOMIC_KEY_REPLACE API

2018-08-14 Thread Alexander Wetzel
Drivers able to correctly replace a in-use key should set NL80211_EXT_FEATURE_ATOMIC_KEY_REPLACE to allow the userspace (e.g. hostapd or wpa_supplicant) to rekey PTK keys. The userspace must detect a PTK rekey attempt and only go ahead with the rekey when the driver has set this flag. If the drive