Re: [PATCH v6 3/3] mac80211: Fix PTK rekey freezes and cleartext leaks

2018-08-28 Thread Johannes Berg
On Tue, 2018-08-28 at 18:27 +0200, Alexander Wetzel wrote: > > This seems a bit weird - we know a likely dangerous thing is happening > > and only print an info message? Why not just prevent this in the first > > place? > > The next version will upgrade that to a warning. Maybe make it rate limi

Re: [PATCH v6 3/3] mac80211: Fix PTK rekey freezes and cleartext leaks

2018-08-28 Thread Alexander Wetzel
Am 28.08.18 um 10:48 schrieb Johannes Berg: > On Tue, 2018-08-14 at 12:42 +0200, Alexander Wetzel wrote: >> >> +/* PTK only using key ID 0 needs special handling on rekey */ >> +if (new_key && sta && ptk0rekey) { >> +local = old_key->local; >> +sdata = old_key->sdata

Re: [PATCH v6 3/3] mac80211: Fix PTK rekey freezes and cleartext leaks

2018-08-28 Thread Johannes Berg
On Tue, 2018-08-14 at 12:42 +0200, Alexander Wetzel wrote: > > + /* PTK only using key ID 0 needs special handling on rekey */ > + if (new_key && sta && ptk0rekey) { > + local = old_key->local; > + sdata = old_key->sdata; > + > + /* Stop TX till we are o

[PATCH v6 3/3] mac80211: Fix PTK rekey freezes and cleartext leaks

2018-08-14 Thread Alexander Wetzel
Rekeying PTK keys without "Extended Key ID for Individually Addressed Frames" did use a procedure not suitable to replace in-use keys and could caused the following issues: 1) Freeze caused by incoming packets: If the local STA installed the key prior to the remote STA we still had the ol