Re: [PATCHv4 5/5] mac80211: add debug knobs for codel

2016-05-06 Thread Dave Taht
On Thu, May 5, 2016 at 11:33 PM, Michal Kazior wrote: > On 6 May 2016 at 07:51, Dave Taht wrote: >> On Thu, May 5, 2016 at 10:27 PM, Michal Kazior >> wrote: >>> On 5 May 2016 at 17:21, Dave Taht wrote: On Thu, May 5, 2016 at 4:00 AM, Michal Kazior wrote: > This adds a few debug

Re: [PATCHv4 5/5] mac80211: add debug knobs for codel

2016-05-05 Thread Michal Kazior
On 6 May 2016 at 07:51, Dave Taht wrote: > On Thu, May 5, 2016 at 10:27 PM, Michal Kazior > wrote: >> On 5 May 2016 at 17:21, Dave Taht wrote: >>> On Thu, May 5, 2016 at 4:00 AM, Michal Kazior >>> wrote: This adds a few debugfs entries to make it easier to test, debug and experiment

Re: [PATCHv4 5/5] mac80211: add debug knobs for codel

2016-05-05 Thread Dave Taht
On Thu, May 5, 2016 at 10:27 PM, Michal Kazior wrote: > On 5 May 2016 at 17:21, Dave Taht wrote: >> On Thu, May 5, 2016 at 4:00 AM, Michal Kazior >> wrote: >>> This adds a few debugfs entries to make it easier >>> to test, debug and experiment. >> >> I might argue in favor of moving all these (

Re: [PATCHv4 5/5] mac80211: add debug knobs for codel

2016-05-05 Thread Michal Kazior
On 5 May 2016 at 17:21, Dave Taht wrote: > On Thu, May 5, 2016 at 4:00 AM, Michal Kazior wrote: >> This adds a few debugfs entries to make it easier >> to test, debug and experiment. > > I might argue in favor of moving all these (inc the fq ones) into > their own dir, maybe "aqm" or "sqm". > > T

Re: [PATCHv4 5/5] mac80211: add debug knobs for codel

2016-05-05 Thread Dave Taht
On Thu, May 5, 2016 at 4:00 AM, Michal Kazior wrote: > This adds a few debugfs entries to make it easier > to test, debug and experiment. I might argue in favor of moving all these (inc the fq ones) into their own dir, maybe "aqm" or "sqm". The mixture of read only stats and configuration vars i

[PATCHv4 5/5] mac80211: add debug knobs for codel

2016-05-05 Thread Michal Kazior
This adds a few debugfs entries to make it easier to test, debug and experiment. Signed-off-by: Michal Kazior --- Notes: v4: * stats adjustments (in-kernel codel has more of them) net/mac80211/debugfs.c | 40 1 file changed, 40 insertions(+) d