Re: [RFC] cfg80211: add control port state to struct cfg80211_connect_resp_params

2017-04-28 Thread Johannes Berg
On Fri, 2017-04-28 at 14:46 +0200, Arend Van Spriel wrote: > I already have the 4-way-hs stuff rebased with modified ATTR_PMK > description and additional length check in nl80211 for it. Jouni > commented on that already in 4-way-hs patch. Cool. > > Do you want to pick that up? I probably can't

Re: [RFC] cfg80211: add control port state to struct cfg80211_connect_resp_params

2017-04-28 Thread Arend Van Spriel
On 28-4-2017 14:02, Johannes Berg wrote: > >> I tested the 4-way-hs (both Personal and 802.1X) with boolean >> parameter similar to what is proposed in the patch for roaming >> "cfg80211/nl80211: add authorized flag to roaming event" and it works >> fine. So I can extend it for use in connect re

Re: [RFC] cfg80211: add control port state to struct cfg80211_connect_resp_params

2017-04-28 Thread Johannes Berg
> I tested the 4-way-hs (both Personal and 802.1X) with boolean > parameter similar to what is proposed in the patch for roaming > "cfg80211/nl80211: add authorized flag to roaming event" and it works > fine. So I can extend it for use in connect result. Just had one > issue regarding the type, ie

Re: [RFC] cfg80211: add control port state to struct cfg80211_connect_resp_params

2017-04-26 Thread Arend Van Spriel
On 26-4-2017 9:20, Johannes Berg wrote: > On Tue, 2017-04-25 at 20:56 +0200, Arend Van Spriel wrote: >> >> You might, but not about this ;-) The other approach I had in mind is >> to only pass the flag for drivers with 4-way-hs support. In that case >> wpa_supp also has to check that to determine w

Re: [RFC] cfg80211: add control port state to struct cfg80211_connect_resp_params

2017-04-26 Thread Johannes Berg
On Tue, 2017-04-25 at 20:56 +0200, Arend Van Spriel wrote: > > You might, but not about this ;-) The other approach I had in mind is > to only pass the flag for drivers with 4-way-hs support. In that case > wpa_supp also has to check that to determine whether the flag should > be taken into accoun

Re: [RFC] cfg80211: add control port state to struct cfg80211_connect_resp_params

2017-04-25 Thread Arend Van Spriel
On 25-4-2017 20:36, Johannes Berg wrote: > On Tue, 2017-04-25 at 20:34 +0200, Arend Van Spriel wrote: > + (cr->port_state != CONTROL_PORT_STATE_UNAUTHORIZED && + nla_put_flag(msg, NL80211_ATTR_PORT_AUTHORIZED)) || (cr->req_ie && >>> >>> This doesn't reall

Re: [RFC] cfg80211: add control port state to struct cfg80211_connect_resp_params

2017-04-25 Thread Johannes Berg
On Tue, 2017-04-25 at 20:34 +0200, Arend Van Spriel wrote: > > > + (cr->port_state != CONTROL_PORT_STATE_UNAUTHORIZED > > > && > > > +  nla_put_flag(msg, NL80211_ATTR_PORT_AUTHORIZED)) || > > >   (cr->req_ie && > > > > > > > This doesn't really make sense - why does unspecified equal

Re: [RFC] cfg80211: add control port state to struct cfg80211_connect_resp_params

2017-04-25 Thread Arend Van Spriel
On 25-4-2017 16:40, Johannes Berg wrote: > On Fri, 2017-04-21 at 22:01 +0100, Arend van Spriel wrote: > >> I have been working on 4-way handshake offloading and one of the >> things discussed was the addition of PORT_AUTHORIZED flag. So >> this is what I came up with, but I suppose wpa_supplicant

Re: [RFC] cfg80211: add control port state to struct cfg80211_connect_resp_params

2017-04-25 Thread Johannes Berg
On Fri, 2017-04-21 at 22:01 +0100, Arend van Spriel wrote: > I have been working on 4-way handshake offloading and one of the > things discussed was the addition of PORT_AUTHORIZED flag. So > this is what I came up with, but I suppose wpa_supplicant wants > to know whether it can expect this attri

[RFC] cfg80211: add control port state to struct cfg80211_connect_resp_params

2017-04-21 Thread Arend van Spriel
When the driver supports offloading of the PTK/GTK handshakes completion of that during connect changes the layer 2 control port state to authorized. This patch allows the driver to pass that state in cfg80211_connect_done() resulting in adding the new flag NL80211_ATTR_PORT_AUTHORIZED in the NL802