Re: [RFC] mac80211: add stop/start logic for software TXQs

2018-05-29 Thread Manikanta Pubbisetty
On 5/28/2018 1:36 PM, Johannes Berg wrote: On Mon, 2018-05-28 at 12:49 +0530, Manikanta Pubbisetty wrote: This doesn't seem right, all the logic that clears the TXQ_STOP etc. still needs to be invoked, otherwise your TXQ will get stuck completely since you'll never run this code again. If th

Re: [RFC] mac80211: add stop/start logic for software TXQs

2018-05-28 Thread Johannes Berg
On Mon, 2018-05-28 at 12:49 +0530, Manikanta Pubbisetty wrote: > > > > This doesn't seem right, all the logic that clears the TXQ_STOP etc. > > still needs to be invoked, otherwise your TXQ will get stuck completely > > since you'll never run this code again. > > If the queues are blocked more th

Re: [RFC] mac80211: add stop/start logic for software TXQs

2018-05-28 Thread Manikanta Pubbisetty
+++ b/net/mac80211/agg-tx.c @@ -213,11 +213,15 @@ static void ieee80211_agg_start_txq(struct sta_info *sta, int tid, bool enable) { struct ieee80211_txq *txq = sta->sta.txq[tid]; + struct ieee80211_local *local = sta->local; struct txq_info *txqi; if (!txq)

Re: [RFC] mac80211: add stop/start logic for software TXQs

2018-05-23 Thread Johannes Berg
On Sat, 2018-05-19 at 01:06 +0530, Manikanta Pubbisetty wrote: > Sometimes, it is required to stop the transmissions momentarily and > resume it later; stopping the txqs becomes very critical in scenarios where > the packet transmission has to be ceased completely. For example, during > the hardwar

[RFC] mac80211: add stop/start logic for software TXQs

2018-05-18 Thread Manikanta Pubbisetty
Sometimes, it is required to stop the transmissions momentarily and resume it later; stopping the txqs becomes very critical in scenarios where the packet transmission has to be ceased completely. For example, during the hardware restart, during off channel operations, when initiating CSA(upon dete