On Wed, 2015-11-11 at 09:45 -0500, Steven Rostedt wrote:
>
> config FLAG_ALL_SET
> default y
> depends on MY_DRIVER_1 && !MY_DRIVER_2 && ... && MY_DRIVER_N
Right. But then I have to list all the drivers, which is rather
annoying. I'd have to add more magic so that you somehow can't build
with
On Wed, 11 Nov 2015 15:29:02 +0100
Johannes Berg wrote:
config MY_DRIVER_1
SELECT SET_FLAG
config MY_DRIVER_2
SELECT SET_FLAG
[...]
config FLAG_ALL_SET
default y
depends on MY_DRIVER_1 && !MY_DRIVER_2 && ... && MY_DRIVER_N
> Right. Basically it'd be one of three options
OnOn Wed, 11 Nov 2015 14:39:16 +0100
> Johannes Berg wrote:
> > > On Wed, 2015-11-11 at 08:34 -0500, Steven Rostedt wrote:
> >
> > > > config MY_DRIVER
> > > > depends on MAC80211
> > > > increment MAC80211_NUM_DRIVERS
> > > > increment MAC80211_HW_MYFLAG
> > >
> > > If
On Wed, 11 Nov 2015 14:39:16 +0100
Johannes Berg wrote:
> On Wed, 2015-11-11 at 08:34 -0500, Steven Rostedt wrote:
>
> > > config MY_DRIVER
> > > depends on MAC80211
> > > increment MAC80211_NUM_DRIVERS
> > > increment MAC80211_HW_MYFLAG
> >
> > If you don't need to check more that >0 w
On Wed, 11 Nov 2015 08:37:52 +0100
Johannes Berg wrote:
> On Wed, 2015-11-11 at 02:22 +0200, Luca Coelho wrote:
> >
> > Now that you have all these options in Kconfig, wouldn't it be
> > possible
> > to remove the calls to the "static" ieee80211_hw_set() in the drivers
> > and somehow set all th
On Wed, 2015-11-11 at 08:34 -0500, Steven Rostedt wrote:
> > config MY_DRIVER
> > depends on MAC80211
> > increment MAC80211_NUM_DRIVERS
> > increment MAC80211_HW_MYFLAG
>
> If you don't need to check more that >0 why not just use SELECT?
> > if (CONFIG_MAC80211_HW_MYFLAG == 0)
> >
On Wed, 2015-11-11 at 02:22 +0200, Luca Coelho wrote:
>
> Now that you have all these options in Kconfig, wouldn't it be
> possible
> to remove the calls to the "static" ieee80211_hw_set() in the drivers
> and somehow set all the flags that are defined in Kconfig
> automatically?
>
Since Kconfig
On Tue, 2015-11-10 at 09:52 +0100, Johannes Berg wrote:
> From: Johannes Berg
>
> There are many drivers with different behaviour, but in a lot of
> systems only a single driver will ever be built. In that case we
> could practically get rid of the code for the paths that this
> driver/device doe
From: Johannes Berg
There are many drivers with different behaviour, but in a lot of
systems only a single driver will ever be built. In that case we
could practically get rid of the code for the paths that this
driver/device doesn't need. Doing that, however, would be rather
dangerous.
As a dec
