Re: [RFC v4 3/8] mac80211: use static keys for hw flags

2015-11-13 Thread Johannes Berg
On Fri, 2015-11-13 at 11:22 -0500, Steven Rostedt wrote: > This sure could use a comment. > >  on = 0, off = 0,  -1 + (0^0) * (1 + 0) = -1 >  on = 0, off = 1,  -1 + (0^1) * (1 + 0) = 0 >  on = 1, off = 0,  -1 + (1^0) * (1 + 1) = 1 >  on = 1, off = 1,  -1 + (1^1) * (1 + 1) = -1 > > The I would al

Re: [RFC v4 3/8] mac80211: use static keys for hw flags

2015-11-13 Thread Steven Rostedt
On Thu, 12 Nov 2015 09:47:48 +0100 Johannes Berg wrote: > index ..e220c5e04406 > --- /dev/null > +++ b/net/mac80211/hwflags.h > @@ -0,0 +1,89 @@ > +/* > + * Copyright 2015Intel Deutschland GmbH > + * > + * This program is free software; you can redistribute it and/or modify > + *

[RFC v4 3/8] mac80211: use static keys for hw flags

2015-11-12 Thread Johannes Berg
From: Johannes Berg There are many drivers with different behaviour, but in a lot of systems only a single driver will ever be built. In that case we could practically get rid of the code for the paths that this driver/device doesn't need. Doing that, however, would be rather dangerous. As a dec