Re: [RFCv2] ath9k: make rxfilter per HW

2015-06-17 Thread Johannes Berg
On Wed, 2015-06-17 at 11:42 +0200, Felix Fietkau wrote: > On 2015-06-17 11:39, Sujith Manoharan wrote: > > Janusz Dziedzic wrote: > >> This is what I have with use_chanctx=1 > >> Jun 17 06:57:54 dell6430 kernel: [53297.753256] xxx ath_calcrxfilter > >> filter: 0x207 > >> > >> 0x00080 is for pr

Re: [RFCv2] ath9k: make rxfilter per HW

2015-06-17 Thread Sujith Manoharan
Felix Fietkau wrote: > The filter is intended to be global in the mac80211 API. > Treating it as per channel-context inside the driver is a bug. Agreed. Sujith -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More m

Re: [RFCv2] ath9k: make rxfilter per HW

2015-06-17 Thread Felix Fietkau
On 2015-06-17 11:39, Sujith Manoharan wrote: > Janusz Dziedzic wrote: >> This is what I have with use_chanctx=1 >> Jun 17 06:57:54 dell6430 kernel: [53297.753256] xxx ath_calcrxfilter >> filter: 0x207 >> >> 0x00080 is for probe_req > > Ok, so the probe_req filter is set before actually initia

Re: [RFCv2] ath9k: make rxfilter per HW

2015-06-17 Thread Sujith Manoharan
Janusz Dziedzic wrote: > This is what I have with use_chanctx=1 > Jun 17 06:57:54 dell6430 kernel: [53297.753256] xxx ath_calcrxfilter > filter: 0x207 > > 0x00080 is for probe_req Ok, so the probe_req filter is set before actually initiating RoC - this appears to be the current design in wpa_

Re: [RFCv2] ath9k: make rxfilter per HW

2015-06-17 Thread Janusz Dziedzic
On 17 June 2015 at 11:00, Sujith Manoharan wrote: > Felix Fietkau wrote: >> mac80211 calculates the filter per hw, not per channel context or per >> vif. Setting it for the current channel context only would mean it might >> be applied to the wrong context. This patch fixes that issue. >> I agree

Re: [RFCv2] ath9k: make rxfilter per HW

2015-06-17 Thread Sujith Manoharan
Felix Fietkau wrote: > mac80211 calculates the filter per hw, not per channel context or per > vif. Setting it for the current channel context only would mean it might > be applied to the wrong context. This patch fixes that issue. > I agree that it might be a useful optimization to selectively app

Re: [RFCv2] ath9k: make rxfilter per HW

2015-06-17 Thread Felix Fietkau
On 2015-06-17 10:20, Sujith Manoharan wrote: > Janusz Dziedzic wrote: >> mac80211 configure rxfilter per HW, >> so we don't need this per channel. >> >> This fix problem when chanctx used and >> ath9k allocate new ath_chanctx. Then we loose >> rxfilter configuration. >> >> Eg. during p2p_find (wh

Re: [RFCv2] ath9k: make rxfilter per HW

2015-06-17 Thread Sujith Manoharan
Janusz Dziedzic wrote: > mac80211 configure rxfilter per HW, > so we don't need this per channel. > > This fix problem when chanctx used and > ath9k allocate new ath_chanctx. Then we loose > rxfilter configuration. > > Eg. during p2p_find (when use_chanctx=1) during > remain on channel, driver cr

Re: [RFCv2] ath9k: make rxfilter per HW

2015-06-17 Thread Felix Fietkau
On 2015-06-17 07:46, Janusz Dziedzic wrote: > mac80211 configure rxfilter per HW, > so we don't need this per channel. > > This fix problem when chanctx used and > ath9k allocate new ath_chanctx. Then we loose > rxfilter configuration. > > Eg. during p2p_find (when use_chanctx=1) during > remain

[RFCv2] ath9k: make rxfilter per HW

2015-06-16 Thread Janusz Dziedzic
mac80211 configure rxfilter per HW, so we don't need this per channel. This fix problem when chanctx used and ath9k allocate new ath_chanctx. Then we loose rxfilter configuration. Eg. during p2p_find (when use_chanctx=1) during remain on channel, driver create new ath_chanctx with incorrect rxfil